Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/ISSUE_TEMPLATE: add bug report and package request issue forms #36411

Merged
merged 1 commit into from Jun 17, 2022

Conversation

classabbyamp
Copy link
Member

@classabbyamp classabbyamp commented Mar 30, 2022

Co-authored-by: @0x5c

This PR replaces the existing markdown-based issue template with two new Github issue forms, one for bug reports and one for package requests.

These ensure that the relevant information is asked for and the required information is provided. They also automagically tag issues with the bug and request tags. If preferred, new bug reports could be also be marked with a second unconfirmed or needs triage label, applied by the form.

Issues that do not fall under these types (like RFCs) can still be opened by clicking the "open a blank issue" button on the template chooser:
image
This can be limited to maintainers by changing blank_issues_enabled to false in .github/ISSUE_TEMPLATE/config.yml if desired.

config.yml can also be used to add additional arbitrary links in the template chooser. Here's an example config.yml and resulting template chooser in another project.

Testing the changes

  • I tested the changes in this PR: YES
    A preview of the rendered templates can be seen here

Copy link
Member

@paper42 paper42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be nice to have a checkbox for electron applications that would add the electron tag and maybe an option (and a new tag) for proprietary software.

.github/ISSUE_TEMPLATE/pkg-request.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/pkg-request.yml Outdated Show resolved Hide resolved
@paper42
Copy link
Member

paper42 commented Mar 30, 2022

I don't like that we have a lot of static text in the request issue template. The whole "Quality Requirements" section could be replaced with a link to Contributing.md.

@classabbyamp
Copy link
Member Author

I think it would be nice to have a checkbox for electron applications that would add the electron tag and maybe an option (and a new tag) for proprietary software.

Those could definitely be included as checkboxes, but it's beyond the scope of issue forms to dynamically add tags like that. The new issue automation can probably do such a thing, but that would require a much larger change (migrating to the new issues/projects entirely). Using a bot that looks for the checkbox/text is another option, which could fit in well with the bot @0x5c has been hacking at that tries to autotag PRs based on changeset contents etc.

I don't like that we have a lot of static text in the request issue template. The whole "Quality Requirements" section could be replaced with a link to Contributing.md.

Should've been a bit more clear there, the explanatory text does not get included in the final issue, it's just for the person filling out the form to read while the form is being filled.

@Chocimier
Copy link
Member

Demoed at https://github.com/Chocimier/void-packages-org/issues, anybody feel free to play with.

We could use it, with some remarks:

  • free-form issue is too hard to find, consider making it a third template
  • checkboxes re-introduce tasks we have just got rid of
  • mandatory checkboxes are dumb on their own anyway
  • in bug report: there is no need for update of package section
  • in bug report: system info should not be mandatory, sometimes it's obvious it doesn't matter
  • in bug report: Bug description section should keep it's current name, Actual behavior
  • in package request: there should be a field to provide homepage

@0x5c
Copy link
Contributor

0x5c commented Mar 31, 2022

I think it would be nice to have a checkbox for electron applications that would add the electron tag and maybe an option (and a new tag) for proprietary software.

As Abby said, that's not directly possible. However, using a bot that looks for a specific variant of a magic string seems prone to breakage.

@0x5c
Copy link
Contributor

0x5c commented Mar 31, 2022

  • checkboxes re-introduce tasks we have just got rid of

This is behaviour we did not expect, as it was different at some point in the past (simply using text instead of markdown checkboxes). We'll do some tests to see what can be done about that, y/n dropdowns are likely to do the trick

  • mandatory checkboxes are dumb on their own anyway

The goal is to limit what can be requested (only released software, which is void's policy on new packages) and limit duplicates reports (which are extra work and are likely to create obsolete reports)

  • in bug report: there is no need for update of package section

You're likely to have someone who considers old, but otherwise functioning, versions of packages to be "bugs". That text can be removed but it's not gonna be a meaningful change since it's not rendered in the final issue anyways.

  • in bug report: system info should not be mandatory, sometimes it's obvious it doesn't matter

I wonder if it's more obvious to maintainers than to bug reporters, and I suspect that without it being provided, the case it's needed would only be discovered beyond the point the reporter has gone AWOL

  • in bug report: Bug description section should keep it's current name, Actual behavior
  • in package request: there should be a field to provide homepage

Consider those fixed

@classabbyamp classabbyamp force-pushed the new-issue-templates branch 4 times, most recently from b0cba30 to 2a9c0b5 Compare April 1, 2022 17:55
@classabbyamp
Copy link
Member Author

Updated to address most of the issues raised, I think. @Chocimier if you want to update your live version, go ahead. The links in the original comment should still work for previewing.

@classabbyamp classabbyamp force-pushed the new-issue-templates branch 3 times, most recently from 6e6efe8 to 26aaa1d Compare April 14, 2022 20:25
.github/ISSUE_TEMPLATE/bug-report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug-report.yml Outdated Show resolved Hide resolved
@classabbyamp
Copy link
Member Author

free-form issue is too hard to find, consider making it a third template

We've found a way to make this work without adding a template:

image

A freeform/blank template is not possible when using issue forms, and a freeform issue form is not really possible (it would have to be a single multi-line input and would add a weird title to the body of the issue). This solution also makes the button to create a blank issue less prominent than the bright green ones for bugs and requests.

The latest updates are available for live preview here: https://github.com/classabbyamp/void-packages-test/issues/new/choose
(note that the current link for freeform issues is pointed to the actual void-packages repo, as it will be after merging. It also currently shows the old issue template since this PR hasn't been merged)

@Chocimier
Copy link
Member

Remarks from paper42 to replace quality requirement with link and to not tag are right. Otherwise quite fine for me.

@0x5c
Copy link
Contributor

0x5c commented Apr 14, 2022

Remarks from paper42 to replace quality requirement with link and to not tag are right. Otherwise quite fine for me.

That text had to be edited to make it more comprehensible to package requesters, since the manual's wording is heavily intended for those who are writing a template, and mentions things like If you believe you have an exception, start a PR and make an argument for why that particular piece of software, while not meeting any of the following requirements, is a good candidate for the Void packages system., which seems fairly nonconstructive in the context of a package request.

@Chocimier
Copy link
Member

edited to make it more comprehensible

I see no meaningful rewording, but if any is needed, please send PR changing proper documentation. Maintaining many copies of same text is not sustainable.

@classabbyamp
Copy link
Member Author

classabbyamp commented Apr 19, 2022

Updated (link goes to quality requirements section).

image

@classabbyamp
Copy link
Member Author

latest version of this is live here. Any critiques?

@Chocimier
Copy link
Member

Quality requirements already say different things here and in contributing.md, can we get rid of the copy?

@classabbyamp
Copy link
Member Author

classabbyamp commented Jun 14, 2022

can we get rid of the copy?

done (assuming you meant manual.md, contributing doesn't list quality requirements)

@Chocimier
Copy link
Member

"is this new" checkbox should go first to avoid wasting reporter's time

@classabbyamp classabbyamp merged commit fa0a7a3 into void-linux:master Jun 17, 2022
@classabbyamp classabbyamp deleted the new-issue-templates branch June 17, 2022 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants