New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.github/ISSUE_TEMPLATE: add bug report and package request issue forms #36411
.github/ISSUE_TEMPLATE: add bug report and package request issue forms #36411
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be nice to have a checkbox for electron applications that would add the electron tag and maybe an option (and a new tag) for proprietary software.
I don't like that we have a lot of static text in the request issue template. The whole "Quality Requirements" section could be replaced with a link to Contributing.md. |
Those could definitely be included as checkboxes, but it's beyond the scope of issue forms to dynamically add tags like that. The new issue automation can probably do such a thing, but that would require a much larger change (migrating to the new issues/projects entirely). Using a bot that looks for the checkbox/text is another option, which could fit in well with the bot @0x5c has been hacking at that tries to autotag PRs based on changeset contents etc.
Should've been a bit more clear there, the explanatory text does not get included in the final issue, it's just for the person filling out the form to read while the form is being filled. |
Demoed at https://github.com/Chocimier/void-packages-org/issues, anybody feel free to play with. We could use it, with some remarks:
|
As Abby said, that's not directly possible. However, using a bot that looks for a specific variant of a magic string seems prone to breakage. |
This is behaviour we did not expect, as it was different at some point in the past (simply using text instead of markdown checkboxes). We'll do some tests to see what can be done about that, y/n dropdowns are likely to do the trick
The goal is to limit what can be requested (only released software, which is void's policy on new packages) and limit duplicates reports (which are extra work and are likely to create obsolete reports)
You're likely to have someone who considers old, but otherwise functioning, versions of packages to be "bugs". That text can be removed but it's not gonna be a meaningful change since it's not rendered in the final issue anyways.
I wonder if it's more obvious to maintainers than to bug reporters, and I suspect that without it being provided, the case it's needed would only be discovered beyond the point the reporter has gone AWOL
Consider those fixed |
b0cba30
to
2a9c0b5
Compare
Updated to address most of the issues raised, I think. @Chocimier if you want to update your live version, go ahead. The links in the original comment should still work for previewing. |
2a9c0b5
to
c6c4ae7
Compare
6e6efe8
to
26aaa1d
Compare
We've found a way to make this work without adding a template: A freeform/blank template is not possible when using issue forms, and a freeform issue form is not really possible (it would have to be a single multi-line input and would add a weird title to the body of the issue). This solution also makes the button to create a blank issue less prominent than the bright green ones for bugs and requests. The latest updates are available for live preview here: https://github.com/classabbyamp/void-packages-test/issues/new/choose |
26aaa1d
to
17d5c72
Compare
Remarks from paper42 to replace quality requirement with link and to not tag are right. Otherwise quite fine for me. |
That text had to be edited to make it more comprehensible to package requesters, since the manual's wording is heavily intended for those who are writing a template, and mentions things like |
17d5c72
to
3c9fcc5
Compare
3c9fcc5
to
8afdd32
Compare
I see no meaningful rewording, but if any is needed, please send PR changing proper documentation. Maintaining many copies of same text is not sustainable. |
8afdd32
to
8185dc3
Compare
6a3338b
to
97718a2
Compare
97718a2
to
c344947
Compare
latest version of this is live here. Any critiques? |
Quality requirements already say different things here and in contributing.md, can we get rid of the copy? |
c344947
to
1108b25
Compare
done (assuming you meant manual.md, contributing doesn't list quality requirements) |
"is this new" checkbox should go first to avoid wasting reporter's time |
Co-authored-by: 0x5c <dev@0x5c.io>
1108b25
to
0783b96
Compare
Co-authored-by: @0x5c
This PR replaces the existing markdown-based issue template with two new Github issue forms, one for bug reports and one for package requests.
These ensure that the relevant information is asked for and the required information is provided. They also automagically tag issues with the
bug
andrequest
tags. If preferred, new bug reports could be also be marked with a secondunconfirmed
orneeds triage
label, applied by the form.Issues that do not fall under these types (like RFCs) can still be opened by clicking the "open a blank issue" button on the template chooser:
This can be limited to maintainers by changing
blank_issues_enabled
tofalse
in.github/ISSUE_TEMPLATE/config.yml
if desired.config.yml
can also be used to add additional arbitrary links in the template chooser. Here's an example config.yml and resulting template chooser in another project.Testing the changes
A preview of the rendered templates can be seen here