Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: noise-suppression-for-voice-0.91 #36491

Closed
wants to merge 1 commit into from
Closed

New package: noise-suppression-for-voice-0.91 #36491

wants to merge 1 commit into from

Conversation

mustaqimM
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: briefly

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)

@paper42 paper42 added the new-package This PR adds a new package label Apr 3, 2022
@prez
Copy link
Contributor

prez commented Apr 6, 2022

DBUILD_LV2_PLUGIN=OFF

very questionable decision. I'd argue LV2 is what you want to have, the others are optional.

@mustaqimM
Copy link
Contributor Author

Well, that's up for discussion. I only kept LADSPA enabled since it can be used system-wide through a pipewire/pulse sink

@prez
Copy link
Contributor

prez commented Apr 7, 2022

Well, that's up for discussion. I only kept LADSPA enabled since it can be used system-wide through a pipewire/pulse sink

The same goes for LV2. I suggest building LV2 only for now.

@github-actions
Copy link

github-actions bot commented Jul 7, 2022

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Jul 7, 2022
@cinerea0
Copy link
Contributor

cinerea0 commented Jul 8, 2022

I think this one is worth keeping open.

@JamiKettunen
Copy link
Contributor

@mustaqimM Could this be bumped to v1.03?

The same goes for LV2. I suggest building LV2 only for now.

@prez Why not both? I'm using this as a PipeWire LADSPA plugin as documented on the README and just tried to make it use the LV2 plugin but was unsuccessful.

I checked lv2ls (from lilv) and this could be problematic:

$ lv2ls
lilv_world_add_plugin(): warning: Duplicate plugin <https://github.com/werman/noise-suppression-for-voice>
lilv_world_add_plugin(): warning: ... found in file:///usr/lib64/lv2/rnnoise_stereo.lv2/
lilv_world_add_plugin(): warning: ... and      file:///usr/lib64/lv2/rnnoise_mono.lv2/ (ignored)
...
https://github.com/werman/noise-suppression-for-voice

Considering the README itself mentions It also would consume 2x resources with regards to using the stereo plugin as compared to the mono one (which I know my microphone only is mono channel).

https://docs.pipewire.org/page_module_filter_chain.html mentions For LV2, this is the plugin URI obtained with lv2ls but I couldn't get it working. I'm very much a newbie when it comes to PipeWire configuration so if someone has a working LV2 mono plugin config I wouldn't mind LADSPA wasn't present in this package; I just want a working configuration with the mono plugin that's all.

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Dec 5, 2022
@JamiKettunen
Copy link
Contributor

JamiKettunen commented Dec 5, 2022

My last comment is still relevant, I'm also still using this daily so it would be rather great to have this in the repos, other alternative voice suppression solutions that I could instead add to my PipeWire setup would also be welcome.

@@ -0,0 +1,12 @@
# Template file for 'noise-suppression-for-voice'
pkgname=noise-suppression-for-voice
version=0.91
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mustaqimM
Copy link
Contributor Author

@JamiKettunen I had to add libsanitizer-devel for it to build the new version, but now it's failing for other arches. I don't have time to see what's up, so if someone wants to take over, please do so.
Also I set the flag -DBUILD_VST_PLUGIN=OFF but in the new version, it still builds it and adds it to /usr/lib/vst3/rnnoise.vst3/Contents/x86_64-linux/rnnoise.so

@github-actions github-actions bot removed the Stale label Dec 6, 2022
@mustaqimM mustaqimM closed this by deleting the head repository Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants