Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3-py7zr: update to 0.18.3. #36538

Closed
wants to merge 5 commits into from

Conversation

TinfoilSubmarine
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

Copy link
Member

@ahesford ahesford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both python3-pybcj and python3-zipfile-deflate64 warn that testing via setup.py is deprecated and don't actually run tests. Can these be moved to python3-pytest? If not, just disable checks in those templates.

srcpkgs/python3-zipfile-deflate64/template Outdated Show resolved Hide resolved
srcpkgs/python3-pyzstd/template Outdated Show resolved Hide resolved
@TinfoilSubmarine
Copy link
Contributor Author

Both python3-pybcj and python3-zipfile-deflate64 warn that testing via setup.py is deprecated and don't actually run tests. Can these be moved to python3-pytest? If not, just disable checks in those templates.

Running with pytest enables some tests for pybcj, but zipfile-deflate64 is...different. The tests aren't included in the source distribution from PyPi, so I tried switching to the GitHub source. Unfortunately, the package uses a zlib submodule and uses an internal zlib header file (zutil.h) not available in zlib-devel. So I think for now I will just skip tests on this one.

enable tests by ignoring/disabling pytest-benchmark
fix tests with custom do_check
enable tests with pytest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants