thefuck: update to 3.32. #36710
Merged
thefuck: update to 3.32. #36710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paper42
reviewed
Apr 18, 2022
|
|
||
| case "$XBPS_TARGET_MACHINE" in | ||
| # archs where go is available - the test suite uses it | ||
| x86_64*|i686*|armv[67]*|aarch64*|ppc64le*) checkdepends+=" go" ;; | ||
| *) make_check=no ;; |
There was a problem hiding this comment.
Could you explain why you removed this line?
There was a problem hiding this comment.
It was giving error in lint and there was no error in the tests on my computer.
There was a problem hiding this comment.
It was giving error in lint
srcpkgs/thefuck/template:20: explain why the tests fail
then you should explain why the tests fail on this line (or right before it).
This is a case statement and your PC probably matches the first case, so make_check=no isn't set for you. Restore this line and add something like ... ;; # go is not available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing