Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cni: update to 1.0.1; cni-plugins: update to 1.1.1; New package: cni-plugin-dnsname-1.3.1 #36714

Closed
wants to merge 3 commits into from

Conversation

Idesmi
Copy link
Contributor

@Idesmi Idesmi commented Apr 15, 2022

Testing the changes

  • I tested the changes in this PR: YES

For cni-plugin-dnsname:

podman network create foo
podman run -dt --name web --network foo docker.io/nginx
podman run -it --name client --network foo docker.io/nginx curl http://web.dns.podman

New package

Local build testing

  • I built this PR locally for my native architecture, x86_64
  • I crossbuilt this PR locally for these architectures :
    • aarch64-musl

@CameronNemo
Copy link
Contributor

LGTM

revision=1
wrksrc="plugins-${version}"
build_style=go
go_import_path="github.com/containernetworking/plugins"
depends="cni>=1.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, are you sure this dependency is needed? I thought the plugins were self-contained...

distfiles="https://github.com/containers/dnsname/archive/v${version}.tar.gz"
checksum=a9319a1829e242b4769697650f7df63a635eda7369ba659618d49056b78bf3ce

do_install() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also just let the go build style do it's thing, then add this in post_install:

vmkdir usr/libexec/cni
mv "${DESTDIR}/usr/bin/dnsname" "${DESTDIR}/usr/libexec/cni/dnsname"

@Idesmi
Copy link
Contributor Author

Idesmi commented May 18, 2022

New request with changes: #37160

@Idesmi Idesmi closed this May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants