Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

criterion FOSS unit test for c/c++ #36935

Closed
wants to merge 3 commits into from

Conversation

ayoubelmhamdi
Copy link

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, (x86_64-LIBC)

Copy link
Member

@paper42 paper42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please look at other similar templates, copy them and modify them for criterion, this is just wrong

@ayoubelmhamdi
Copy link
Author

this is the first PR for this pkg

@paper42 paper42 added the new-package This PR adds a new package label May 2, 2022
Copy link
Member

@paper42 paper42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • remove the archs restriction
  • run xlint on the templates and fix issues it finds
  • rebase on top of master to make CI run
  • squash all 3 commits to one and use the proper commit message as described in CONTRIBUTING.md, look at common/build-styles/meson and remove *depends that are not necessary
  • remove $depends, they are detected automatically
  • remove cmake from hostmakedepends, it's not necessary
  • use hostmakedepends and makedepends correctly and make sure this also cross builds

@github-actions
Copy link

github-actions bot commented Aug 1, 2022

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Aug 1, 2022
@github-actions github-actions bot closed this Aug 16, 2022
@ayoubelmhamdi ayoubelmhamdi deleted the criterion branch August 16, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants