Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: tlpui-1.5.0 #36982

Closed
wants to merge 3 commits into from

Conversation

Visone-Selektah
Copy link

Testing the changes

  • I tested the changes in this PR: YES
  • I built this PR locally for my native architecture, x86_64-musl

@Chocimier
Copy link
Member

We accept no new python 2 packages, use python3 dependencies.
Use build style instead of defining own do functions, and fix issues reported by xlint.

depends="tlp python-gobject"
short_desc="A GTK user interface for TLP written in Python"
maintainer="Visone Selektah <victortebar@gmail.com>"
license="GPL2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPL-2.0-or-later

version=1.5.0
revision=1
wrksrc="TLPUI-${pkgname}-${version}"
makedepends="python-setuptools"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be hostmakedepends instead. That will fix the cross-build.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's my first time, thanks for the points!

homepage="https://github.com/d4nj1/TLPUI"
distfiles="https://github.com/d4nj1/TLPUI/archive/refs/tags/tlpui-${version}.tar.gz"
checksum=37c31f88798c5dc2b7e77e49bcc2ef3d374abb93b2f903b2cd836fbcc5947b9a
make_check=no
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gtk+3 in depends and checkdepends="${depends}" takes tests till Gtk-WARNING **: cannot open display: that is fixable too

@Visone-Selektah
Copy link
Author

I can't find any way to fix the Display error so, I'm gonna close this PR and will make it again when I have it all figure it out.
Thanks 4 the help!!

@Visone-Selektah Visone-Selektah deleted the tlpui branch May 6, 2022 08:55
@paper42
Copy link
Member

paper42 commented May 6, 2022

I can't find any way to fix the Display error so, I'm gonna close this PR and will make it again when I have it all figure it out. Thanks 4 the help!!

add xvfb-run to $checkdepends and set make_check_pre="xvfb-run" and please don't open a new PR, just reopen this one

@Visone-Selektah
Copy link
Author

Thank you all for your help!

@paper42 paper42 added the new-package This PR adds a new package label May 7, 2022
wrksrc="TLPUI-${pkgname}-${version}"
build_style="python3-module"
hostmakedepends="python3-setuptools"
depends="gtk+3 tlp python3-gobject "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
depends="gtk+3 tlp python3-gobject "
depends="gtk+3 tlp python3-gobject"

just a tiny mistake

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Aug 7, 2022
@motorto
Copy link
Contributor

motorto commented Aug 8, 2022

@Visone-Selektah your package is working, just need to clean that extra space and maybe bump it to the last 1.5.0-5.

@Visone-Selektah
Copy link
Author

Hi!
Sorry for the silent, I didn't see the notification.
I'll close this PR, you already send a new one with the new version.

@Visone-Selektah
Copy link
Author

New PR was send with the latest version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants