New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: tlpui-1.5.0 #36982
New package: tlpui-1.5.0 #36982
Conversation
We accept no new python 2 packages, use python3 dependencies. |
srcpkgs/tlpui/template
Outdated
depends="tlp python-gobject" | ||
short_desc="A GTK user interface for TLP written in Python" | ||
maintainer="Visone Selektah <victortebar@gmail.com>" | ||
license="GPL2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPL-2.0-or-later
srcpkgs/tlpui/template
Outdated
version=1.5.0 | ||
revision=1 | ||
wrksrc="TLPUI-${pkgname}-${version}" | ||
makedepends="python-setuptools" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be hostmakedepends
instead. That will fix the cross-build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's my first time, thanks for the points!
srcpkgs/tlpui/template
Outdated
homepage="https://github.com/d4nj1/TLPUI" | ||
distfiles="https://github.com/d4nj1/TLPUI/archive/refs/tags/tlpui-${version}.tar.gz" | ||
checksum=37c31f88798c5dc2b7e77e49bcc2ef3d374abb93b2f903b2cd836fbcc5947b9a | ||
make_check=no |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gtk+3 in depends and checkdepends="${depends}"
takes tests till Gtk-WARNING **: cannot open display:
that is fixable too
I can't find any way to fix the Display error so, I'm gonna close this PR and will make it again when I have it all figure it out. |
add |
Thank you all for your help! |
wrksrc="TLPUI-${pkgname}-${version}" | ||
build_style="python3-module" | ||
hostmakedepends="python3-setuptools" | ||
depends="gtk+3 tlp python3-gobject " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
depends="gtk+3 tlp python3-gobject " | |
depends="gtk+3 tlp python3-gobject" |
just a tiny mistake
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
@Visone-Selektah your package is working, just need to clean that extra space and maybe bump it to the last 1.5.0-5. |
Hi! |
New PR was send with the latest version |
Testing the changes