Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode: update to 1.69.0 #36991

Merged
merged 1 commit into from
Jul 11, 2022
Merged

vscode: update to 1.69.0 #36991

merged 1 commit into from
Jul 11, 2022

Conversation

atk
Copy link
Contributor

@atk atk commented May 5, 2022

  • take care of new tracking server

Testing the changes

  • I tested the changes in this PR: YES, but one error was found: at the moment, the internal terminal does not work.

@atk atk changed the title vscode: update to 1.67.0 WIP: vscode: update to 1.67.0 May 5, 2022
@atk
Copy link
Contributor Author

atk commented May 5, 2022

@shizonic if you have any idea about the terminal, I'm currently too tired to have a closer look. Maybe tomorrow.

@atk atk force-pushed the vscode-1.67.0 branch 2 times, most recently from 414fab0 to edcdf48 Compare May 19, 2022 07:21
@atk atk changed the title WIP: vscode: update to 1.67.0 WIP: vscode: update to 1.67.2 May 19, 2022
@shizonic
Copy link
Contributor

shizonic commented Jul 6, 2022

@atk Sorry I am too busy for months... Any progress for newest release 1.68.1?

@atk
Copy link
Contributor Author

atk commented Jul 6, 2022

We're currently blocked by the missing electron-18 update; using an older electron version breaks the terminal view.

@shizonic
Copy link
Contributor

shizonic commented Jul 6, 2022

@atk Oh I see. Thanks for informing.

Any idea if and when electron 18 lands in the repo?

@atk
Copy link
Contributor Author

atk commented Jul 6, 2022

I had opened a package request issue, but unfortunately, there's currently no one to pick it up.

@paper42
Copy link
Member

paper42 commented Jul 10, 2022

Electron 19 is now packaged, can we use it?

@shizonic
Copy link
Contributor

Electron 19 is now packaged, can we use it?

Gonna have a look into it by tomorrow.

take care of new tracking server
@atk
Copy link
Contributor Author

atk commented Jul 10, 2022

I guess I beat you to it :)

And my assumption that electron13 was breaking the terminal seems to have been right, because with electron19, it works again.

@atk atk changed the title WIP: vscode: update to 1.67.2 WIP: vscode: update to 1.69.0 Jul 10, 2022
@atk atk changed the title WIP: vscode: update to 1.69.0 vscode: update to 1.69.0 Jul 10, 2022
@shizonic
Copy link
Contributor

I guess I beat you to it :)

And my assumption that electron13 was breaking the terminal seems to have been right, because with electron19, it works again.

Nice work, dude. Thank you!

@Johnnynator Johnnynator merged commit f92833e into void-linux:master Jul 11, 2022
@atk atk deleted the vscode-1.67.0 branch July 11, 2022 10:32
@negativeExponent
Copy link

negativeExponent commented Jul 11, 2022

i'm having issue running this version of vscode (including the 1.69.0_1 on main repo). the app closes as soon as you click on File on menu bar.

maybe this verbose log will help something: https://pastebin.com/A2W7TQ4S

@Johnnynator
Copy link
Member

i'm having issue running this version of vscode (including the 1.69.0_1 on main repo). the app closes as soon as you click on File on menu bar.

maybe this verbose log will help something: https://pastebin.com/A2W7TQ4S

Are you on musl or glibc?

@negativeExponent
Copy link

glibc

@brxken128
Copy link

i'm having issue running this version of vscode (including the 1.69.0_1 on main repo). the app closes as soon as you click on File on menu bar.

maybe this verbose log will help something: https://pastebin.com/A2W7TQ4S

This happens for me also, on 1.69.0_1 with glibc. In addition to this, scrolling and just about everything else is slow/sluggish and has large response times.

The context menu/text also seems to be broken with gnome 42.0_1, although I don't know if it's limited to gnome. The bar with the blue box is supposed to be the menu bar, and clicking the first part (which I assume is the File button) will indeed crash the program. I've tried with all extensions disabled too - no dice.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants