New package: xfce4-calculator-plugin 0.7.1 #37188
Conversation
IT-DEVS-Group
commented
May 18, 2022
IT-DEVS-Group
commented
- I tested the changes in this PR: YES
- I built this PR locally for my native architecture, (x86_64 musl, 86_64 glib)
| configure_args="--with-locales-dir=/usr/share/locale" | ||
| hostmakedepends="pkg-config intltool" | ||
| makedepends="xfce4-panel-devel" | ||
| short_desc="Battery monitor plugin for the Xfce panel" |
There was a problem hiding this comment.
The description doesn't look like it matches the name.
There was a problem hiding this comment.
The description doesn't look like it matches the name.
Fixed
common/environment/setup/misc.sh
Outdated
| @@ -18,5 +18,6 @@ GNU_SITE="https://ftp.gnu.org/gnu" | |||
| FREEDESKTOP_SITE="https://freedesktop.org/software" | |||
| KDE_SITE="https://download.kde.org/stable" | |||
| VIDEOLAN_SITE="https://download.videolan.org/pub/videolan" | |||
| XFCE_SITE="https://archive.xfce.org" | |||
There was a problem hiding this comment.
Drop the commit with this change, we agreed to not add this variable in another PR.
There was a problem hiding this comment.
You also can't use this variable in the package when it's not defined.
|
ha-ha. mess. ok. done and bye |
| short_desc="Calculator plugin for the Xfce4 panel" | ||
| license="GPL-2.0-or-later, LGPL-2.0-or-later" | ||
| homepage="https://docs.xfce.org/panel-plugins/xfce4-calculator-plugin" | ||
| changelog="https://gitlab.xfce.org/panel-plugins/xfce4-calculator-plugin/-/blob/master/NEWS" |
There was a problem hiding this comment.
and so it goes. anyway, when xfce changes the server name, with this speed of maintainers and this approach, the packages will not be available for a long time. then they'll fix it.
There was a problem hiding this comment.
raw is prefered but not required
There was a problem hiding this comment.
and so it goes. anyway, when xfce changes the server name, with this speed of maintainers and this approach, the packages will not be available for a long time. then they'll fix it.
I have no idea what you are talking about.
raw changelog is prefered which means packages should use it if it's available, please change it. Also, you will have to fix CI before this is merged.
|
Why did you close this? This PR would be merged if you fixed CI and adressed my review. |
