New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New packages: wyrd-1.5.3 and ocaml-curses-1.0.10 #37214
Conversation
srcpkgs/wyrd/template
Outdated
version=1.5.3 | ||
revision=1 | ||
build_style=gnu-configure | ||
#configure_args="" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused, aren't those lines necessary? Did you mean lines 6-8?
maintainer="Barbaross <cullenrss@gmail.com>" | ||
license="GPL-2.0-or-later" | ||
homepage="https://gitlab.com/wyrd-calendar/wyrd" | ||
distfiles="${homepage}/-/archive/${version}/wyrd-${version}.tar.gz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try the tarball at "${homepage}/-/jobs/artifacts/${version}/raw/wyrd-${version}.tar.xz?job=release"
.
It contains a pre-built copy of the manual, so you can skip building it yourself and only build the wyrd
executable with make wyrd
, no need to run prep-devtree.sh
as well.
checksum=1d7936dd10b795a17bbce06ae14079eb36120f26fd7bd27b522f8df5196790e7 | ||
|
||
pre_configure() { | ||
./prep-devtree.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is only needed with autoconf, not with dune (or the release tarball).
conf_files="/etc/wyrdrc" | ||
short_desc="Ncurses front-end to Remind" | ||
maintainer="Barbaross <cullenrss@gmail.com>" | ||
license="GPL-2.0-or-later" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPL-2.0-only
makedepends="ncurses-devel" | ||
short_desc="Objective Caml libs for curses" | ||
maintainer="Barbaross <cullenrss@gmail.com>" | ||
license="GPL-3.0-or-later" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGPL-2.1
makedepends="ncurses-devel" | ||
short_desc="Objective Caml libs for curses" | ||
maintainer="Barbaross <cullenrss@gmail.com>" | ||
license="GPL-3.0-or-later" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be "LGPL-2.1-or-later"
, according to https://github.com/mbacarella/curses/blob/main/curses.opam#L7
version=1.5.3 | ||
revision=1 | ||
build_style=gnu-configure | ||
hostmakedepends="ocaml camlp5 ocaml-curses texlive texlive-LuaTeX python3 opam" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there should be no need for python3
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
Testing the changes
New package
Local build testing
See #35401 for my thoughts/progress packaging this. Also closes #35401.
As mentioned in the linked issue, the build process for the documentation required me to hit enter a few times. I'm not sure how to automate it entirely. Feedback greatly appreciated.