Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starship: update to 1.7.1. #37430

Merged
merged 1 commit into from
Jun 12, 2022
Merged

starship: update to 1.7.1. #37430

merged 1 commit into from
Jun 12, 2022

Conversation

JuniorSuperTux
Copy link
Contributor

@JuniorSuperTux JuniorSuperTux commented Jun 7, 2022

starship: update to 1.7.1

Testing the changes

  • I tested the changes in this PR: NO

Copy link
Contributor

@0x5c 0x5c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That version of starship does not support the rust version we have (requiring 1.59 while we have 1.57) and cannot build.

The checksum= line must be changed to match the distfile anytime the version changes. Packages simply cannot build if it is not matching.

@JuniorSuperTux JuniorSuperTux changed the title starship: update to 1.7.1. [WIP] starship: update to 1.7.1. Jun 7, 2022
starship: update to 1.7.1
@JuniorSuperTux JuniorSuperTux marked this pull request as draft June 7, 2022 08:49
@JuniorSuperTux
Copy link
Contributor Author

How do I update rust-bootstrap? Since 1.59.0 isn't in https://repo-default.voidlinux.org/distfiles

@classabbyamp
Copy link
Member

there is already an in-progress PR to update rust (#37232)

@tranzystorekk
Copy link
Contributor

tranzystorekk commented Jun 7, 2022

Rust 1.61 is there, i think this PR is good to proceed

(the changes to the rust/libgit2 templates are not necessary here)

@cinerea0
Copy link
Contributor

cinerea0 commented Jun 8, 2022

As the maintainer of the package, I'll handle updating it when the Rust update PR is merged. I think we all appreciate your interest, though!

@JuniorSuperTux JuniorSuperTux marked this pull request as ready for review June 8, 2022 00:18
@JuniorSuperTux JuniorSuperTux changed the title [WIP] starship: update to 1.7.1. starship: update to 1.7.1. Jun 8, 2022
@cinerea0
Copy link
Contributor

cinerea0 commented Jun 8, 2022

Currently testing these changes and they work for me, now a member just has to approve the check workflows.

@0x5c
Copy link
Contributor

0x5c commented Jun 8, 2022

The commits should be squashed, see CONTRIBUTING.md

@JuniorSuperTux
Copy link
Contributor Author

The commits should be squashed, see CONTRIBUTING.md

Done

@JuniorSuperTux
Copy link
Contributor Author

Hello, since I'm new to this, I wonder if there are any essential steps that I have not done correctly? Or is it just a priority of merging pull requests?

@classabbyamp
Copy link
Member

Hello, since I'm new to this, I wonder if there are any essential steps that I have not done correctly? Or is it just a priority of merging pull requests?

nope, you're fine. Things just move slowly sometimes.

@paper42
Copy link
Member

paper42 commented Jun 12, 2022

Hello, since I'm new to this, I wonder if there are any essential steps that I have not done correctly? Or is it just a priority of merging pull requests?

I tested the changes in this PR: NO

Please test your PR next time

@paper42 paper42 merged commit 6ad71c7 into void-linux:master Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants