-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
starship: update to 1.7.1. #37430
starship: update to 1.7.1. #37430
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That version of starship does not support the rust version we have (requiring 1.59
while we have 1.57
) and cannot build.
The checksum=
line must be changed to match the distfile anytime the version changes. Packages simply cannot build if it is not matching.
starship: update to 1.7.1
How do I update |
there is already an in-progress PR to update rust (#37232) |
Rust 1.61 is there, i think this PR is good to proceed (the changes to the rust/libgit2 templates are not necessary here) |
As the maintainer of the package, I'll handle updating it when the Rust update PR is merged. I think we all appreciate your interest, though! |
Currently testing these changes and they work for me, now a member just has to approve the check workflows. |
The commits should be squashed, see CONTRIBUTING.md |
Done |
Hello, since I'm new to this, I wonder if there are any essential steps that I have not done correctly? Or is it just a priority of merging pull requests? |
nope, you're fine. Things just move slowly sometimes. |
Please test your PR next time |
starship: update to 1.7.1
Testing the changes