-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: hatch-1.2.1 #37514
Merged
leahneukirchen
merged 4 commits into
void-linux:master
from
jcgruenhage:python3-hatch-1.2.1_1
Jun 29, 2022
Merged
New package: hatch-1.2.1 #37514
leahneukirchen
merged 4 commits into
void-linux:master
from
jcgruenhage:python3-hatch-1.2.1_1
Jun 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chocimier
reviewed
Jun 11, 2022
288e9ae
to
c247260
Compare
paper42
reviewed
Jun 11, 2022
5c335c3
to
d449445
Compare
Hello, I didn't know you were working on this already. I have been trying to package this for a few days and finally managed to get a working build. Since you have this PR already, please feel free to reuse any part of my commit if you wish. |
paper42
reviewed
Jun 18, 2022
This was referenced Jun 20, 2022
Please rebase. |
d449445
to
1e606ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
Bikeshedding opportunities
As they aren't just libraries, but also CLI tools, do hatch/hatchling need theConsidering no one commented on this bit, I've decided to just get rid of.python3-
prefix? I personally don't like it, and would argue in favor of removing it.There's nearly no testing happening here, but that's due to the deps either requiring git checkouts with submodules, or themselves to be installed for testing. Any opinions on this? I'd prefer to have some amount of automatic testing here and not just a "JC has run this on his laptop once", considering that these are likely to be fairly central Python packagesthere are a few tests failing now, but they are being run and there's a hundred times more tests that do work as intended. The ones failing where it's expecting to be running /usr/bin/python, but is actually running /usr/bin/python3 or similar things, which is fine IMO.Is a major update of python3-click something that might need additional testing? 29 of our packages depend on it, but on the other hand, it's probably fine, right?Has been updated outside of this PR.Fixes #37334