Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: hatch-1.2.1 #37514

Merged
merged 4 commits into from
Jun 29, 2022

Conversation

jcgruenhage
Copy link
Contributor

@jcgruenhage jcgruenhage commented Jun 11, 2022

Testing the changes

  • I tested the changes in this PR: briefly

Bikeshedding opportunities

  • As they aren't just libraries, but also CLI tools, do hatch/hatchling need the python3- prefix? I personally don't like it, and would argue in favor of removing it. Considering no one commented on this bit, I've decided to just get rid of.
  • There's nearly no testing happening here, but that's due to the deps either requiring git checkouts with submodules, or themselves to be installed for testing. Any opinions on this? I'd prefer to have some amount of automatic testing here and not just a "JC has run this on his laptop once", considering that these are likely to be fairly central Python packages there are a few tests failing now, but they are being run and there's a hundred times more tests that do work as intended. The ones failing where it's expecting to be running /usr/bin/python, but is actually running /usr/bin/python3 or similar things, which is fine IMO.
  • Is a major update of python3-click something that might need additional testing? 29 of our packages depend on it, but on the other hand, it's probably fine, right? Has been updated outside of this PR.

Fixes #37334

@jcgruenhage jcgruenhage force-pushed the python3-hatch-1.2.1_1 branch 3 times, most recently from 5c335c3 to d449445 Compare June 11, 2022 14:43
@classabbyamp classabbyamp added the new-package This PR adds a new package label Jun 11, 2022
@icp1994
Copy link
Contributor

icp1994 commented Jun 17, 2022

Hello, I didn't know you were working on this already. I have been trying to package this for a few days and finally managed to get a working build. Since you have this PR already, please feel free to reuse any part of my commit if you wish.

srcpkgs/python3-click/template Outdated Show resolved Hide resolved
srcpkgs/python3-click/template Outdated Show resolved Hide resolved
@leahneukirchen
Copy link
Member

Please rebase.

@jcgruenhage jcgruenhage changed the title New package: python3-hatch-1.2.1 New package: hatch-1.2.1 Jun 26, 2022
@jcgruenhage jcgruenhage marked this pull request as ready for review June 26, 2022 10:04
@leahneukirchen leahneukirchen merged commit a6df068 into void-linux:master Jun 29, 2022
@jcgruenhage jcgruenhage deleted the python3-hatch-1.2.1_1 branch August 9, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Package request] python hatch
6 participants