Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: wayclip-0.3 #37515

Closed
wants to merge 1 commit into from
Closed

New package: wayclip-0.3 #37515

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 11, 2022 •
edited by ghost

Testing the changes

  • I tested the changes in this PR: YES

@ghost ghost marked this pull request as draft June 11, 2022 13:10
@ghost ghost marked this pull request as ready for review June 11, 2022 13:27
@ghost
Copy link
Author

ghost commented Jun 11, 2022 •
edited by ghost

Closes #37510

@dkwo
Copy link
Contributor

dkwo commented Jun 11, 2022

It builds fine on x86_64-musl.
Should it depend on wlroots?

@ghost

This comment was marked as off-topic.

Sign in to view
@ghost

This comment was marked as outdated.

Sign in to view
@ghost ghost requested a review from paper42 June 11, 2022 15:00
@classabbyamp classabbyamp added the new-package This PR adds a new package label Jun 11, 2022
@ghost

This comment was marked as spam.

Sign in to view
@ghost ghost changed the title New package: wayclip-0.2 New package: wayclip-0.3 Jul 3, 2022
jcgruenhage
jcgruenhage approved these changes Jul 3, 2022
View reviewed changes
Copy link
Contributor

@jcgruenhage jcgruenhage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked at upstream, looked at this template. Looks good to me. Good to merge IMO.

@jcgruenhage
Copy link
Contributor

@nvidialinuxuser can you rebase this?

@ghost

This comment was marked as off-topic.

Sign in to view
@jcgruenhage
Copy link
Contributor

@nvidialinuxuser Rebase is something you do locally on your checked out branch: git fetch origin && git rebase origin/master should do it. Your branch has split off from master at some point, and rebasing on master basically means that the changes to master since your branch has split off are taken and your changes are applied on top of the new state of the master branch.

If you have trouble with git, https://github.com/git-guides is a good resource, and once you're comfortable with those basics, https://git-rebase.io/ would be a good next step. If you want someone else to take over for this package, until you're more comfortable with git, I'd be happy to do so.

@jcgruenhage
Copy link
Contributor

Ah, I see that this is on a patch-1 branch, so you worked on this completely in the web interface? In that case it might be a bit more complicated.

@ghost

This comment was marked as off-topic.

Sign in to view
@ghost

This comment was marked as off-topic.

Sign in to view
@jcgruenhage jcgruenhage mentioned this pull request Jul 3, 2022
Merged
@ghost ghost closed this Jul 3, 2022
@ghost ghost deleted the patch-1 branch July 3, 2022 17:45
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paper42 paper42 Awaiting requested review from paper42

Assignees
No one assigned
Labels
new-package This PR adds a new package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dkwo @jcgruenhage @classabbyamp @paper42