xbps-src: check for existing packages before syncing chroot repodata #37595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This significantly speeds up the package building process for build scripts etc. that run './xbps-src pkg ...' on a long list of packages that may already have up-to-date local packages built when configured with XBPS_PRESERVE_PKGS set.
|
Looks good to me. Leaving check in other places is correct. |
|
Cool, I'll mark this as ready for review then :) |
ericonr
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
This significantly speeds up the package building process for build scripts etc. that run
./xbps-src pkg ...on a long list of packages that may already have up-to-date local packages built when configured withXBPS_PRESERVE_PKGSset.I still have one question: what to do with the existing call tocheck_existing_pkgincommon/xbps-src/libexec/build.sh? The script appears to be executed from a few other scripts as well so I left it alone for now.Example with a single package
Before this patch:
After this patch:
Previously this would add up to about a minute of waiting for essentially no reason if 30 packages already have up-to-date local packages, while with this patch it would only take about 2 seconds to come to the same conclusion with the same package list.