Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: hunspell-sl_SI-2020.12.31 #37631

Merged
merged 1 commit into from Jun 26, 2022
Merged

New package: hunspell-sl_SI-2020.12.31 #37631

merged 1 commit into from Jun 26, 2022

Conversation

chloris-pale-green
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

New package

@paper42 paper42 added the new-package This PR adds a new package label Jun 21, 2022
@classabbyamp
Copy link
Member

it's unfortunate that there's no versioning in the distfile URL, but I don't see a way around that.

to allow for detection of available updates, please add a srcpkgs/hunspell-sl-SI/update with the contents pattern='<span>\K[\d.]+(?=</span>)'

@chloris-pale-green
Copy link
Contributor Author

to allow for detection of available updates, please add a srcpkgs/hunspell-sl-SI/update with the contents pattern='<span>\K[\d.]+(?=</span>)'

Thank you for the improvement suggestion. I have added the update file and incremented the package revision number.

@paper42
Copy link
Member

paper42 commented Jun 25, 2022

and incremented the package revision number.

Don't do that and squash the commits.

@chloris-pale-green
Copy link
Contributor Author

I've reverted the revision to 1 and squashed the three commits since "New package," but had issues when pushing them back to origin (Updates were rejected because the tip of your current branch is behind). I've had to merge and ended up with an ugly commit history.

If desired, I can just fork the repo again, make a "clean" package in a single commit, and issue another pull request.

@sgn
Copy link
Member

sgn commented Jun 25, 2022

I've reverted the revision to 1 and squashed the three commits since "New package," but had issues when pushing them back to origin (Updates were rejected because the tip of your current branch is behind).

git push -f origin master

@chloris-pale-green
Copy link
Contributor Author

Thanks for the advice, @sgn! It worked. The package should now be in a single tidy commit.

@sgn sgn merged commit 76f9b74 into void-linux:master Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants