Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libwacom: update to 2.5.0 #37677

Closed
wants to merge 9 commits into from
Closed

libwacom: update to 2.5.0 #37677

wants to merge 9 commits into from

Conversation

hervyqa
Copy link
Contributor

@hervyqa hervyqa commented Jun 25, 2022

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, (x86_64-musl)

Screenshot_20220625_143106

@hervyqa
Copy link
Contributor Author

hervyqa commented Jun 25, 2022

[0/1] Running all tests.
1/8 libwacom:all / files-in-git                  SKIP            0.01s   exit status 77
2/8 libwacom:all+valgrind / test-load            OK              0.14s
3/8 libwacom:all+valgrind / test-tablet-validity OK              0.16s
4/8 libwacom:all+valgrind / test-stylus-validity OK              0.05s
5/8 libwacom:all+valgrind / test-svg-validity    OK              0.10s
6/8 libwacom:all+valgrind / test-dbverify        OK              0.45s
7/8 libwacom:all / test-ltversion                OK              0.01s
8/8 libwacom:all / pytest                        FAIL           28.94s   exit status 1

Any suggestion?
@paper42

@classabbyamp
Copy link
Member

the reverse shlibdeps of libwacom should be bumped for this, there's a change to the so version.

re: pytest: it seems that the test that's failing is trying to use these files but isn't finding them

@0-st
Copy link
Contributor

0-st commented Sep 26, 2022

@hervyqa Did you get version 2.4.0 to build?

@hervyqa
Copy link
Contributor Author

hervyqa commented Oct 2, 2022

@hervyqa Did you get version 2.4.0 to build?

I haven't tried it yet.

@hervyqa
Copy link
Contributor Author

hervyqa commented Nov 21, 2022

re: pytest: it seems that the test that's failing is trying to use these files but isn't finding them

any idea?

@hervyqa hervyqa changed the title libwacom: update to 2.3.0 libwacom: update to 2.5.0 Nov 21, 2022
@classabbyamp
Copy link
Member

disable those tests or add the files

@hervyqa
Copy link
Contributor Author

hervyqa commented Nov 21, 2022

isn't it already disabled?

configure_args+=" -Dtests=disabled"

how to add the files?

@classabbyamp
Copy link
Member

look at the line before that:

if [ -z "${XBPS_CHECK_PKGS}" ]; then
        configure_args+=" -Dtests=disabled"

if you want to add the files, add them as a distfile

@hervyqa
Copy link
Contributor Author

hervyqa commented Nov 21, 2022

maybe it has something to do with this issue linuxwacom/libwacom#515

@triallax
Copy link
Contributor

See my PR #41569, which should fix the test failure.

@hervyqa
Copy link
Contributor Author

hervyqa commented Feb 5, 2023

fix: #41569

@hervyqa hervyqa closed this Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants