Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update openssl to 3 series #37681

Closed
wants to merge 10 commits into from
Closed

update openssl to 3 series #37681

wants to merge 10 commits into from

Conversation

dkwo
Copy link
Contributor

@dkwo dkwo commented Jun 25, 2022

[ci skip]

Note to self:

  • use xrevbump "bump for openssl-3.0" $(xbps-query -Rs libssl.so -p shlib-requires | cut -d ':' -f 1 | xargs -n1 xbps-uhelper getpkgname) and same for libcrypto, or use sort -u file1 file2.

@paper42
Copy link
Member

paper42 commented Jun 25, 2022

I am pretty sure not all packages work with openssl 3, converting to draft

@dkwo
Copy link
Contributor Author

dkwo commented Jun 27, 2022

@Duncaen Do you know how to fix the xbps config failure?

@Duncaen
Copy link
Member

Duncaen commented Jun 27, 2022

The released version is missing this commit void-linux/xbps@db17669, but its not compatible with openssl 3 anyways removing -Werror fixes that, since its just using a bunch of functions deprecated in openssl>=3.

@leahneukirchen
Copy link
Member

Please delay until 3.0.5.

@dkwo dkwo changed the title update openssl to 3.0.4 update openssl to 3 series Jul 6, 2022
@dkwo
Copy link
Contributor Author

dkwo commented Jul 23, 2022

After rebuilding xbps, it complains that the RSA signature is not valid, and refuses to install packages.
Any hint how to deal with this?

@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added Stale and removed Stale labels Oct 22, 2022
@dkwo
Copy link
Contributor Author

dkwo commented Nov 15, 2022

Actually, xbps fails one test:

===> Failed tests
libxbps/shell/obsoletefiles_test:replace_package_same_files  ->  failed: 0 != 2 (0 != 2)  [0.260s]

Copy link
Member

@paper42 paper42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also keep libssl1.1 and libcrypto1.1 packaged separately for backwards compatibility

srcpkgs/openssl/template Outdated Show resolved Hide resolved
srcpkgs/openssl/template Outdated Show resolved Hide resolved
srcpkgs/openssl/template Outdated Show resolved Hide resolved
@dkwo
Copy link
Contributor Author

dkwo commented Jan 25, 2023

I would also keep libssl1.1 and libcrypto1.1 packaged separately for backwards compatibility

Should I then keep an openssl1.1-compat package or similar?

@paper42
Copy link
Member

paper42 commented Jan 25, 2023

I would also keep libssl1.1 and libcrypto1.1 packaged separately for backwards compatibility

Should I then keep an openssl1.1-compat package or similar?

I might be wrong, but I think we only need libssl1.1 and libcrypto1.1, not what is in the openssl package, so it should be a package called libssl1.1 with a subpackage libcrypto1.1 I think.

@dkwo dkwo force-pushed the openssl3 branch 5 times, most recently from 679ba92 to f621bcb Compare January 26, 2023 19:06
@classabbyamp
Copy link
Member

3.1.2 is available

@classabbyamp
Copy link
Member

php8.0 ossl3 patchs can be found at https://git.alpinelinux.org/aports/tree/testing/php8?h=master

@classabbyamp
Copy link
Member

I'll have some patches for xbps soon

@dkwo
Copy link
Contributor Author

dkwo commented Aug 9, 2023

@classabbyamp Indeed, should we update to 3.1 series, or stay with 3.0, which is LTS?
as for php8.0, I tried to do that, but then consesus seemed to be remove it, see #42231 (comment)
Great that you can patch xbps, that's the most important thing.

@classabbyamp
Copy link
Member

ok fair enough wrt php8

@dkwo
Copy link
Contributor Author

dkwo commented Aug 17, 2023

@classabbyamp With your recent changes to xbps, it only fails this test:

===> Failed tests
libxbps/shell/obsoletefiles_test:replace_package_same_files  ->  failed: 0 != 2 (0 != 2)  [0.196s]

but this also fails on the master branch, so it's likely unrelated to this update.
Apart from that, it seems to work fine.

@classabbyamp
Copy link
Member

yes, I've been running builds of all openssl revdeps. I have a lot to push

@classabbyamp
Copy link
Member

classabbyamp commented Aug 20, 2023

hm didn't mean to push that to this PR, not sure how that happened. feel free to force push and overwrite that

@dkwo
Copy link
Contributor Author

dkwo commented Aug 20, 2023

Sure. If you find any failure that is openssl-related, feel free to push it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants