libopenraw: split the pixbuf loader into subpackage #37749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duncaen
reviewed
Jun 30, 2022
sgn
reviewed
Jul 1, 2022
The pixbuf loader can cause issues loading files and isn't always needed. The pixbuf loader is also considered deprecated upstream, so it should probably be split into its own package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
Someone had this issue on the GNOME matrix, libopenraw-pixbuf-loader wasn't loading their CR2 file correctly and I can reproduce it.
Without the libopenraw pixbufloader, eog was able to load the CR2 file correctly. The pixbuf loader is currently apart of the libopenraw package which is a dependency of xfce thumbler.
Seeing as the pixbuf loader part isn't needed by xfce or eog and the pixbuf loader is considered deprecated upstream, probably best to split it into its own subpackage so people can install it if they really need it.
https://gitlab.freedesktop.org/libopenraw/libopenraw/-/issues/10