Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

element-desktop: update to 1.11.0. #37908

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

jcgruenhage
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

The platform support patch has been removed because it's been merged upstream in element-hq/element-desktop#376.

I've tested this locally on x86_64, works as expected.

@apprehensions
Copy link
Contributor

Output:
Official Linux/ia32 support is deprecated.
For more info: https://electronjs.org/blog/linux-32bit-support

@Johnnynator
Copy link
Member

Can you update the PR to use electron 19.

@jcgruenhage
Copy link
Contributor Author

@Johnnynator done

@Johnnynator
Copy link
Member

Also needs to be changed in /srcpkgs/element-desktop/files/element-desktop

@jcgruenhage
Copy link
Contributor Author

... yeah. Building again and trying it out with that changed as well now

@jcgruenhage
Copy link
Contributor Author

So, since I updated electron element is super slow. Extremely slow. Very much unusable...

@jcgruenhage
Copy link
Contributor Author

To put some numbers behind that: I'm currently waiting 5 to 15 seconds for switching between chats and even typed characters don't appear right away :/

@Johnnynator
Copy link
Member

Musl or glibc? Also how is the performance when using upstream electron?

@jcgruenhage
Copy link
Contributor Author

glibc. How do I try it with upstream electron? Don't know much about electron sadly (or maybe not sadly? :D)

@jcgruenhage
Copy link
Contributor Author

I've also noticed some crashes, element-desktop crashed on me for the third time now today...

@Johnnynator
Copy link
Member

The issue is specific to our electron19, using the upstream one downloaded from https://github.com/electron/electron/releases/tag/v19.0.8 does not exhibit the same issues.

I did probably do most of my tests with a too simple Electron app.

@Johnnynator
Copy link
Member

Can you retest with rev 2 of electron19. The issues seem to be fixed at least for me.

@jcgruenhage
Copy link
Contributor Author

Tried with rev2, works as expected, performance problem is gone.

@Johnnynator Johnnynator merged commit f96045c into void-linux:master Jul 13, 2022
@jcgruenhage jcgruenhage deleted the element-desktop-1.11.0_1 branch August 9, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants