Fix mutter rpath when cross compiling #37924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were using pc_sysrootdir which is an issue since this is used for the rpath.
The typelibdir variable was including pc_sysrootdir, which breaks the rpath when cross compiling.
The typelibdir variable was including pc_sysrootdir, which breaks the rpath when cross compiling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
Not sure why we are running into this issue now since we have been patching it like this since forever, but typelibdir is just used for the rpath and currently it is returning stuff like
/usr/aarch64-linux-musl//usr/lib64/mutter-10when cross compiling due topc_sysrootdir.