Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: New package: finvizfinance-0.14.3 #38161

Closed
wants to merge 1 commit into from
Closed

WIP: New package: finvizfinance-0.14.3 #38161

wants to merge 1 commit into from

Conversation

jason1987d
Copy link
Contributor

No description provided.

@paper42
Copy link
Member

paper42 commented Jul 20, 2022

  • try to build the package on your own computer before pushing
  • do NOT push every 10 seconds
  • do not delete the PR template and fill it

@jason1987d
Copy link
Contributor Author

My apologies. Discovered the xbps-src pkg -Q switch now. Even though I've included python3-BeautifulSoup4 as a hostmakedepends, makedepends, and depends, it's still not finding 'bs4' in its check mode.

@jason1987d jason1987d changed the title New package: finvizfinance-0.14.3 WIP: New package: finvizfinance-0.14.3 Jul 20, 2022
@classabbyamp
Copy link
Member

add it to checkdepends (or, even better: checkdepends="$depends")

@jason1987d
Copy link
Contributor Author

add it to checkdepends (or, even better: checkdepends="$depends")

Sorry, meant that it failed even with that.

@classabbyamp classabbyamp added the new-package This PR adds a new package label Jul 21, 2022
@tranzystorekk
Copy link
Contributor

tranzystorekk commented Jul 21, 2022

This patch should fix the bs4 problem:

diff --git a/setup.py b/setup.py
index 3671638..3e2030b 100644
--- a/setup.py
+++ b/setup.py
@@ -18,7 +18,7 @@ INSTALL_REQUIRES = [
       'pandas',
       'datetime',
       'requests',
-      'bs4',
+      'beautifulsoup4',
       'lxml'
 ]
 CLASSIFIERS = [

You also need to package https://pypi.org/project/DateTime/

@tranzystorekk
Copy link
Contributor

Also, since this is purely API, the package should be named "python3-finvizfinance"

@jason1987d jason1987d closed this Jul 21, 2022
@jason1987d jason1987d deleted the finvizfinance branch July 21, 2022 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants