Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batsignal: update to 1.5.0. #38252

Merged
merged 1 commit into from
Jul 25, 2022
Merged

batsignal: update to 1.5.0. #38252

merged 1 commit into from
Jul 25, 2022

Conversation

motorto
Copy link
Contributor

@motorto motorto commented Jul 24, 2022

Testing the changes

  • I tested the changes in this PR: briefly

Local build testing

  • I built this PR locally for my native architecture, x86_64{glibc,musl}

electrickite/batsignal#21

@motorto motorto force-pushed the batsignal-1.5.0 branch 2 times, most recently from 1d9f51e to de6f766 Compare July 25, 2022 08:15
@motorto
Copy link
Contributor Author

motorto commented Jul 25, 2022

@sgn Is that what you meant ? (Pushed changes to makefile) I didn't understand what you meant. (It still doesn't compile this way) gives me:

=> batsignal-1.5.0_1: running do_build ...
cc -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe    -fdebug-prefix-map=/builddir/batsignal-1.5.0=.      -c -o batsignal.o batsignal.c
sed "s/VERSION/1.5.0/g" < batsignal.1.in > batsignal.1
In file included from batsignal.c:22:
/usr/include/libnotify/notify.h:25:10: fatal error: glib.h: No such file or directory
   25 | #include <glib.h>
      |          ^~~~~~~~
compilation terminated.
make: *** [<builtin>: batsignal.o] Error 1
=> ERROR: batsignal-1.5.0_1: do_build: '${make_cmd} CC="$CC" CXX="$CXX" LD="$LD" AR="$AR" RANLIB="$RANLIB" CPP="$CPP" AS="$AS" OBJCOPY="$OBJCOPY" OBJDUMP="$OBJDUMP" CFLAGS="$CFLAGS" CXXFLAGS="$CXXFLAGS" LDFLAGS="$LDFLAGS" ${makejobs} ${make_build_args} ${make_build_target}' exited with 2
=> ERROR:   in do_build() at common/build-style/gnu-makefile.sh:9

Which makes me think that I am overriding still the flags

sgn pushed a commit to motorto/void-packages that referenced this pull request Jul 25, 2022
@sgn sgn force-pushed the batsignal-1.5.0 branch 2 times, most recently from 01890f8 to 22fdd9a Compare July 25, 2022 12:05
@sgn
Copy link
Member

sgn commented Jul 25, 2022

@motorto I fixed the patch for you.

@motorto
Copy link
Contributor Author

motorto commented Jul 25, 2022

Thanks @sgn was failing to pass the $libs it seems, thanks for the huge help !

@sgn sgn merged commit 30db5f5 into void-linux:master Jul 25, 2022
@motorto motorto deleted the batsignal-1.5.0 branch July 27, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants