-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
batsignal: update to 1.5.0. #38252
Merged
Merged
batsignal: update to 1.5.0. #38252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motorto
force-pushed
the
batsignal-1.5.0
branch
2 times, most recently
from
July 25, 2022 08:15
1d9f51e
to
de6f766
Compare
sgn
reviewed
Jul 25, 2022
sgn
reviewed
Jul 25, 2022
sgn
reviewed
Jul 25, 2022
@sgn Is that what you meant ? (Pushed changes to makefile) I didn't understand what you meant. (It still doesn't compile this way) gives me:
Which makes me think that I am overriding still the flags |
sgn
pushed a commit
to motorto/void-packages
that referenced
this pull request
Jul 25, 2022
sgn
force-pushed
the
batsignal-1.5.0
branch
2 times, most recently
from
July 25, 2022 12:05
01890f8
to
22fdd9a
Compare
@motorto I fixed the patch for you. |
Thanks @sgn was failing to pass the $libs it seems, thanks for the huge help ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing
electrickite/batsignal#21