xbps-src: do not allow /usr/share/man/man
#38279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use build_style=configure as this is not a gnu-configure script. Specifically the --manprefix argument works different in gnu configure.
classabbyamp
approved these changes
Jul 26, 2022
paper42
reviewed
Jul 26, 2022
| @@ -108,6 +108,11 @@ hook() { | |||
| error=1 | |||
| fi | |||
|
|
|||
| if [[ -d ${PKGDESTDIR}/usr/share/man/man ]]; then | |||
There was a problem hiding this comment.
All conditions around this line use single [, double [ shouldn't be necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is only a single package (
coturn) using the directory because the--manprefixconfigure argument from thegnu-configurebuild style uses/usr/share/manwhile the configure script expected/usr/share.