Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gopass-jsonapi: update to 1.14.3. #38289

Closed
wants to merge 1 commit into from

Conversation

kuhnchris
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, x86_64-glibc

Previous revision accidently didn't set the -X main.version=${version} making gopassbridge complain about "please upgrade your gopass version to >1.8.3" despite having 1.13.X installed.

For future references, a test client for this is found in the gopassbridge repository (test-client directory) and a check can be invoked like this:

(master) gopassbridge/test-client % echo '{"type": "getVersion"}' | ./test-client | gopass-jsonapi listen                                                                                                
3{"version":"1.14.3","major":1,"minor":14,"patch":3}%       

@kuhnchris
Copy link
Contributor Author

On a related note: the go_ldflags parameter is also not mentioned in the Contribution Guide / Manual. I just accidently found it while checking other templates like docker-compose or revive

@classabbyamp
Copy link
Member

commit message should be gopass-jsonapi: add version to go_ldflags or something similar

@kuhnchris
Copy link
Contributor Author

commit message should be gopass-jsonapi: add version to go_ldflags or something similar

really? I thought it was disallowed to add anything aside what xbump pre-fills? I can change the commit message, sure, just making sure I don't cause any issues.

@paper42
Copy link
Member

paper42 commented Jul 29, 2022

commit message should be gopass-jsonapi: add version to go_ldflags or something similar

really? I thought it was disallowed to add anything aside what xbump pre-fills? I can change the commit message, sure, just making sure I don't cause any issues.

xbump can only detect updates and new packages, so every other commit has to named manually. This is not an update, so the commit shouldn't say it is.

@classabbyamp
Copy link
Member

done in a3bf334

@kuhnchris
Copy link
Contributor Author

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants