Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: subtitlecomposer-0.7.1 #38384

Closed
wants to merge 1 commit into from

Conversation

hervyqa
Copy link
Contributor

@hervyqa hervyqa commented Jul 31, 2022

Fix: #38023

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64)

Screenshot_20220731_113250

@hervyqa hervyqa changed the title New packages: subtitlecomposer-0.7.1 New package: subtitlecomposer-0.7.1 Jul 31, 2022
@classabbyamp classabbyamp added the new-package This PR adds a new package label Jul 31, 2022
@hervyqa hervyqa marked this pull request as draft July 31, 2022 03:28
@hervyqa hervyqa marked this pull request as ready for review July 31, 2022 03:50
Comment on lines 6 to 12
hostmakedepends="extra-cmake-modules kcoreaddons kdoctools gettext pkg-config
pkg-config qt5-host-tools qt5-qmake kconfig xorg-server-xvfb"
makedepends="blas-devel ffmpeg-devel jack-devel ktextwidgets-devel kio-devel
ktextwidgets-devel kcodecs-devel kross-devel kxmlgui-devel ki18n-devel
libopenal-devel pocketsphinx sonnet-devel"
depends="kcoreaddons ktextwidgets kio kcodecs kross kxmlgui ki18n libopenal
ffmpeg sonnet"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
hostmakedepends="extra-cmake-modules kcoreaddons kdoctools gettext pkg-config
pkg-config qt5-host-tools qt5-qmake kconfig xorg-server-xvfb"
makedepends="blas-devel ffmpeg-devel jack-devel ktextwidgets-devel kio-devel
ktextwidgets-devel kcodecs-devel kross-devel kxmlgui-devel ki18n-devel
libopenal-devel pocketsphinx sonnet-devel"
depends="kcoreaddons ktextwidgets kio kcodecs kross kxmlgui ki18n libopenal
ffmpeg sonnet"
hostmakedepends="extra-cmake-modules kcoreaddons kdoctools gettext pkg-config
qt5-host-tools qt5-qmake"
makedepends="blas-devel ffmpeg-devel jack-devel ktextwidgets-devel kio-devel
ktextwidgets-devel kcodecs-devel kross-devel kxmlgui-devel ki18n-devel
libopenal-devel libpocketsphinx-devel sonnet-devel"

I was able to compile & run successfully with just these dependencies

You shouldn't need to specify the depends because they'll get auto-detected, and you had some unnecessary things in hostmakedepends

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pocketsphinx should be libpocketsphinx-devel, but it will not work, even though configure works fine:

-- Could NOT find PocketSphinx: Found unsuitable version "0.8", but required is at least "5" (found /usr/lib/libpocketsphinx.so;/usr/lib/libsphinxbase.so;/usr/lib/libsphinxad.so;/usr/lib/libpulse.so;/usr/lib/libpulse-simple.so;/usr/lib/libpthread.so;/usr/lib/libm.so;/usr/lib/libsamplerate.so;/usr/lib/libsndfile.so)
-- Have NOT Found PocketSphinx - Speech plugin will not be built

pocketsphinx v5 is currently not released (except for a release candidate which isn't tagged)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pocketsphinx v5 is currently not released (except for a release candidate which isn't tagged)

maybe take a release from sourceforge. idk.
https://sourceforge.net/projects/cmusphinx/files/pocketsphinx/5prealpha/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on what's said in the github repo, that's not a stable release, I think.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't need to specify the depends because they'll get auto-detected, and you had some unnecessary things in hostmakedepends

I still add kconfig in hostmakedepends so it can still compile.

https://github.com/void-linux/void-packages/runs/7597149424?check_suite_focus=true#step:7:168

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on what's said in the github repo, that's not a stable release, I think.

I guess so too. hmmm..

@hervyqa hervyqa force-pushed the subtitlecomposer branch 2 times, most recently from 0e9b05d to 1e149ae Compare July 31, 2022 08:21
@hervyqa hervyqa force-pushed the subtitlecomposer branch 3 times, most recently from fe8e7ab to 782eb65 Compare September 27, 2022 03:24
@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Dec 28, 2022
@github-actions github-actions bot closed this Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: subtitlecomposer
2 participants