New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scons: update to 4.4.0 #38396
scons: update to 4.4.0 #38396
Conversation
24caa9e
to
819f8a8
Compare
will reopen later gotta dig through the setup.py test failures that did not occur on local testing |
Don't close and reopen PRs. Fix the issue, amend the commit, and force repush to the branch. |
If its a work-in-progress, mark it WIP or draft. |
82278aa
to
ed3361d
Compare
Had to exclude two tests that fail in github workflows, but pass locally. |
ceb745c
to
2c5ff52
Compare
i had to Whichever way you guys wanna go, if you want tests i can build from the tree and create templates for the missing python3 deps. Or we can use the release tarball without checks? |
|
This may break building some packages that rely on
Edit: s/is going to/may/ because the first package I checked broke, but so far none of the other have |
Ill go through and build each and make sure. Most of them should be fine, SCons didnt change much between the last version in the repo |
Looks like they're all good except |
Testing the changes
Local build testing
I also 'adopted' the package as it was orphaned. I still use it for a few packages and would be willing to maintain it