Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scons: update to 4.4.0 #38396

Merged
merged 1 commit into from Aug 2, 2022
Merged

scons: update to 4.4.0 #38396

merged 1 commit into from Aug 2, 2022

Conversation

wpbirney
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • x86_64-musl

I also 'adopted' the package as it was orphaned. I still use it for a few packages and would be willing to maintain it

@wpbirney wpbirney force-pushed the scons branch 2 times, most recently from 24caa9e to 819f8a8 Compare July 31, 2022 17:24
@wpbirney
Copy link
Contributor Author

will reopen later gotta dig through the setup.py test failures that did not occur on local testing

@wpbirney wpbirney closed this Jul 31, 2022
@abenson
Copy link
Contributor

abenson commented Jul 31, 2022

Don't close and reopen PRs. Fix the issue, amend the commit, and force repush to the branch.

@abenson
Copy link
Contributor

abenson commented Jul 31, 2022

If its a work-in-progress, mark it WIP or draft.

@wpbirney wpbirney reopened this Jul 31, 2022
@wpbirney wpbirney changed the title scons: update to 4.4.0 WIP: scons: update to 4.4.0 Jul 31, 2022
@wpbirney wpbirney force-pushed the scons branch 5 times, most recently from 82278aa to ed3361d Compare July 31, 2022 22:22
@wpbirney
Copy link
Contributor Author

Had to exclude two tests that fail in github workflows, but pass locally.
Last remaining issue is the man page i just noticed is not being generated. Will correct that next

srcpkgs/scons/template Outdated Show resolved Hide resolved
srcpkgs/scons/template Outdated Show resolved Hide resolved
srcpkgs/scons/template Outdated Show resolved Hide resolved
@wpbirney wpbirney force-pushed the scons branch 3 times, most recently from ceb745c to 2c5ff52 Compare August 1, 2022 17:21
@wpbirney wpbirney changed the title WIP: scons: update to 4.4.0 scons: update to 4.4.0 Aug 1, 2022
@wpbirney
Copy link
Contributor Author

wpbirney commented Aug 1, 2022

i had to make_check=no. I talked with the developer of scons and was told the release tarballs do not contain the tests. If we want to test it, we have to build from the repo tree instead and also package some extra python3 deps that are missing from the void repos (unless pip is allowed to be used in templates, which i don't believe it is).

Whichever way you guys wanna go, if you want tests i can build from the tree and create templates for the missing python3 deps. Or we can use the release tarball without checks?

@abenson
Copy link
Contributor

abenson commented Aug 1, 2022

make_check=no like you have it (with the comment) is fine. Let's stick with the release tarball.

@abenson
Copy link
Contributor

abenson commented Aug 1, 2022

This may break building some packages that rely on Scons. Need to go through and work on making sure they're fixed.

Edit: s/is going to/may/ because the first package I checked broke, but so far none of the other have

@wpbirney
Copy link
Contributor Author

wpbirney commented Aug 2, 2022

Ill go through and build each and make sure. Most of them should be fine, SCons didnt change much between the last version in the repo

@abenson
Copy link
Contributor

abenson commented Aug 2, 2022

Looks like they're all good except mixxx.

@abenson abenson merged commit 26fee1f into void-linux:master Aug 2, 2022
@wpbirney wpbirney deleted the scons branch April 4, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants