New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: civetweb-1.15 #38419
New package: civetweb-1.15 #38419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's some extra indentation in your subpackage definitions too
you'll need to squash this into 1 commit and force-push |
Did I need to add libcivetweb.so.1 to common/shlibs? |
yes, and I think there should be a libcivetweb_package() {
short_desc+=" - library"
pkg_install() {
vmove usr/lib/*.so.*
}
} |
0f3590b
to
b2329ef
Compare
Should I add this subpackage as dependency for main package? I tested and didn't find any issue without it. |
no, it should be automatically detected |
the devel package should be called libcivetweb-devel now |
looks decent now, can you squash your commits and force-push? |
I need to squash all commits from "New package" to now into one? |
yes, it should all be in a single commit called |
67e8b7b
to
aaaff33
Compare
hm I think something got messed up there |
there's still a |
My bad, I ran I fixed depency of libcivetweb on libcivetweb-devel, where was wrong (was civetweb). |
3c666d6
to
a97e47e
Compare
Now everything should be ok. |
please remove the commit message body |
978c3b5
to
ad683a8
Compare
done |
I'll close this PR cause It's a dependency of another package I built, and it'll be referenced there #38537 |
Testing the changes
New package
Local build testing