Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: civetweb-1.15 #38419

Closed
wants to merge 2 commits into from
Closed

Conversation

gcarlos64
Copy link

Testing the changes

  • I tested the changes in this PR: briefly

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_664-LIBC)

Copy link
Member

@classabbyamp classabbyamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's some extra indentation in your subpackage definitions too

srcpkgs/civetweb/template Outdated Show resolved Hide resolved
srcpkgs/civetweb/template Outdated Show resolved Hide resolved
srcpkgs/civetweb/template Outdated Show resolved Hide resolved
srcpkgs/civetweb/template Outdated Show resolved Hide resolved
@classabbyamp classabbyamp added the new-package This PR adds a new package label Aug 2, 2022
@classabbyamp
Copy link
Member

you'll need to squash this into 1 commit and force-push

@gcarlos64
Copy link
Author

Did I need to add libcivetweb.so.1 to common/shlibs?

@classabbyamp
Copy link
Member

yes, and I think there should be a libcivetweb subpackage too

libcivetweb_package() {
	short_desc+=" - library"
	pkg_install() {
		vmove usr/lib/*.so.*
	}
}

@gcarlos64 gcarlos64 force-pushed the master branch 2 times, most recently from 0f3590b to b2329ef Compare August 2, 2022 17:40
@gcarlos64
Copy link
Author

yes, and I think there should be a libcivetweb subpackage too

libcivetweb_package() {
	short_desc+=" - library"
	pkg_install() {
		vmove usr/lib/*.so.*
	}
}

Should I add this subpackage as dependency for main package? I tested and didn't find any issue without it.

@classabbyamp
Copy link
Member

no, it should be automatically detected

@classabbyamp
Copy link
Member

the devel package should be called libcivetweb-devel now

@classabbyamp
Copy link
Member

looks decent now, can you squash your commits and force-push?

@gcarlos64
Copy link
Author

looks decent now, can you squash your commits and force-push?

I need to squash all commits from "New package" to now into one?

@classabbyamp
Copy link
Member

yes, it should all be in a single commit called New package: civetweb-1.15

@gcarlos64 gcarlos64 force-pushed the master branch 2 times, most recently from 67e8b7b to aaaff33 Compare August 2, 2022 20:07
@classabbyamp
Copy link
Member

hm I think something got messed up there

@classabbyamp
Copy link
Member

there's still a libcivetweb-devel/var/db/xbps/pkgdb-0.38.plist in there

@gcarlos64
Copy link
Author

hm I think something got messed up there

My bad, I ran git add srcpkgs and added garbage.

I fixed depency of libcivetweb on libcivetweb-devel, where was wrong (was civetweb).

@gcarlos64 gcarlos64 force-pushed the master branch 2 times, most recently from 3c666d6 to a97e47e Compare August 2, 2022 20:21
@gcarlos64
Copy link
Author

Now everything should be ok.

@paper42
Copy link
Member

paper42 commented Aug 3, 2022

please remove the commit message body

@gcarlos64 gcarlos64 force-pushed the master branch 2 times, most recently from 978c3b5 to ad683a8 Compare August 3, 2022 16:40
@gcarlos64
Copy link
Author

please remove the commit message body

done

@gcarlos64
Copy link
Author

I'll close this PR cause It's a dependency of another package I built, and it'll be referenced there #38537

@gcarlos64 gcarlos64 closed this Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants