Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tpm2-tss: update to 3.2.0. #38567

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Conversation

motorto
Copy link
Contributor

@motorto motorto commented Aug 9, 2022

Testing the changes

  • I tested the changes in this PR: briefly

Local build testing

  • I built this PR locally for my native architecture, x86_64-glibc
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • armv6l

Because of the rebuild because of the autoconf update (#38412), the current version doesn't compile with autoconf-2.7.1 so updating it so that it can be built with the new version. (easier than patching the software)

Someone could check if this package works properly ?

@ndowens You being the package maintainer does it look okay to you

@tranzystorekk
Copy link
Contributor

pkgconfig files in tpm2-tss-devel have a blank Version field, so tpm2-totp breaks

@motorto
Copy link
Contributor Author

motorto commented Aug 21, 2022

pkgconfig files in tpm2-tss-devel have a blank Version field, so tpm2-totp breaks

Thanks for the testing could you please tell me what you did to test the package (especially to encounter te error)

@tranzystorekk
Copy link
Contributor

@motorto I temporarily rebased #38515 onto this change and tried to build it

@motorto
Copy link
Contributor Author

motorto commented Aug 21, 2022

Found the issue, could you check if it works now.

srcpkgs/tpm2-tss/template Outdated Show resolved Hide resolved
srcpkgs/tpm2-tss/template Outdated Show resolved Hide resolved
srcpkgs/tpm2-tss/template Outdated Show resolved Hide resolved
@motorto
Copy link
Contributor Author

motorto commented Sep 10, 2022

@paper42 done!

Removed the rm -rf command since all the jobs were failing with:

=> tpm2-tss-3.2.0_1: running post_install ...
rm: cannot remove '/destdir//tpm2-tss-3.2.0/etc/tmpfiles.d': No such file or directory
=> ERROR: tpm2-tss-3.2.0_1: post_install: 'rm -r ${DESTDIR}/etc/tmpfiles.d' exited with 1

revision=1
build_style=gnu-configure
configure_args="--disable-weakcrypto --with-crypto=mbed --disable-fapi"
hostmakedepends="autoconf-archive automake libtool pkg-config doxygen libltdl-devel"
hostmakedepends="shadow autoconf-archive automake libtool pkg-config doxygen libltdl-devel"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shadow is here for adding a tss user to the chroot, I don't think we want that, is it possible to patch this out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gentoo seems do to that :) Could you have a look ?

@paper42 paper42 merged commit 7e3b026 into void-linux:master Sep 13, 2022
@motorto motorto deleted the tpm2-tss_update_autoconf branch September 22, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants