Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

farstream: drop unused python-devel in *depends, fix tests. #38612

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

TinfoilSubmarine
Copy link
Contributor

@TinfoilSubmarine TinfoilSubmarine commented Aug 11, 2022

Testing the changes

  • I tested the changes in this PR: briefly (ran extended tests)

python headers haven't been needed since Farstream 0.2: https://gitlab.freedesktop.org/farstream/farstream/-/commit/73891c28fa27d5e65a71762e826f13747d743588

The tests were already broken prior to this change, but the patch I added gets them building, but then they fail when they run...

@TinfoilSubmarine TinfoilSubmarine changed the title farstream: drop unused python-devel in *depends. [WIP] farstream: drop unused python-devel in *depends. Aug 11, 2022
@TinfoilSubmarine TinfoilSubmarine changed the title [WIP] farstream: drop unused python-devel in *depends. [WIP] farstream: drop unused python-devel in *depends, fix tests. Aug 11, 2022
@TinfoilSubmarine
Copy link
Contributor Author

Wow, these tests are really flaky. I've run them several times on my machine and had different results:

  1. all 12 pass
  2. raw/conference fails
  3. rtp/codecs fails

And here, last time it failed on raw/conference, but this time it failed 3 (rtp/codecs, raw/conference, and rtp/conference).

@classabbyamp
Copy link
Member

Wow, these tests are really flaky

maybe make_check should be set to extended or ci-skip

Also fix tests with patch and checkdepends
@TinfoilSubmarine TinfoilSubmarine changed the title [WIP] farstream: drop unused python-devel in *depends, fix tests. farstream: drop unused python-devel in *depends, fix tests. Aug 12, 2022
@classabbyamp classabbyamp merged commit 10f17c5 into void-linux:master Aug 12, 2022
@TinfoilSubmarine TinfoilSubmarine deleted the update/farstream branch August 22, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants