Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PolyMC: Update Java runtime dependencies #38648

Closed
wants to merge 1 commit into from
Closed

PolyMC: Update Java runtime dependencies #38648

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions srcpkgs/PolyMC/template
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
# Template file for 'PolyMC'
pkgname=PolyMC
version=1.4.1
revision=1
revision=2
build_style=cmake
configure_args="-DLauncher_BUILD_PLATFORM=Void
-DLauncher_VERSION_BUILD=${revision}"
hostmakedepends="extra-cmake-modules openjdk8 pkg-config qt5-host-tools
hostmakedepends="extra-cmake-modules openjdk17 pkg-config qt5-host-tools
qt5-qmake scdoc"
makedepends="qt5-devel"
depends="virtual?java-runtime qt5-svg qt5-imageformats xrandr"
depends="openjdk17-jre qt5-svg qt5-imageformats xrandr"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? virtual?java-runtime will accept any package that provides java-runtime virtual dependency, this includes both openjdk17-jre and the current distro-wide default of openjdk8-jre.

If you install openjdk17-jre you should be able to remove openjdk8-jre, or why not keep both. You could also install openjdk17-jre before PolyMC and then openjdk8-jre won't be pulled in.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nvm attempting to install PolyMC pulls in openjdk11-jre by default for me on x86_64-musl, wonder what exactly makes that the case... Either way this is a bit of a nuanced issue, perhaps @classabbyamp can comment better.

I previously suggested mentioning the existance of PolyMC's README.voidlinux but it seems that was completely lost in the comments, but the file should already exist as /usr/share/doc/PolyMC/README.voidlinux on your system.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nvm attempting to install PolyMC pulls in openjdk11-jre by default for me on x86_64-musl, wonder what exactly makes that the case... Either way this is a bit of a nuanced issue, perhaps @classabbyamp can comment better.

I previously suggested mentioning the existance of PolyMC's README.voidlinux but it seems that was completely lost in the comments, but the file should already exist as /usr/share/doc/PolyMC/README.voidlinux on your system.

Fair, but README or not, this still means that the package wouldn't have accurate dependencies which puts into question the point of deps in the first place. Not to mention the extra work for new users who'll have to switch one version out for another.

short_desc="Custom launcher for Minecraft"
maintainer="Philipp David <pd@3b.pm>"
license="GPL-3.0-only"
Expand Down