Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: bazel-buildtools-5.1.0 #38813

Closed
wants to merge 1 commit into from

Conversation

nc0fr
Copy link

@nc0fr nc0fr commented Aug 21, 2022

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • x86_64-musl
    • Should support cross compilation using the Go standard toolchain

Note: As I specified a few weeks ago in #38207, I decided to release the different Bazel buildtools into a single package to avoid polluting the repository, since these tools are often installed together.

Note: The package is named bazel-buildtools to be clear that it is for Bazel, since a lot of ecosystems do have tools under the name "buildtools".

Note: This is not a sub-package of bazel (unpublished yet) since they do not directly require Bazel and building Bazel from source is very long, which could be annoying for those who only needs the build tools (a sub-package is only executed after the main package's installation phase.

@classabbyamp classabbyamp added the new-package This PR adds a new package label Aug 21, 2022
Copy link
Member

@classabbyamp classabbyamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by using the go build_style, it should work better on cross

srcpkgs/bazel-buildtools/template Outdated Show resolved Hide resolved
srcpkgs/bazel-buildtools/template Outdated Show resolved Hide resolved
srcpkgs/bazel-buildtools/template Outdated Show resolved Hide resolved
@nc0fr
Copy link
Author

nc0fr commented Aug 23, 2022

I removed the additional comment in the commit message since it was the source of the xlint job error

@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Nov 28, 2022
@nc0fr
Copy link
Author

nc0fr commented Nov 29, 2022

Closing the issue due to the lack of answer or any news.

@nc0fr nc0fr closed this Nov 29, 2022
@nc0fr nc0fr deleted the feat/bazel-buildtools branch February 5, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants