Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New packages: fl{aa,amp,cluster,log,msg,net,wkey,wrap} #38816

Closed
wants to merge 8 commits into from
Closed

New packages: fl{aa,amp,cluster,log,msg,net,wkey,wrap} #38816

wants to merge 8 commits into from

Conversation

Goorzhel
Copy link
Contributor

@Goorzhel Goorzhel commented Aug 21, 2022

/label new-package wip
@classabbyamp (#38771 (comment))

I need help with:

  1. picking a good name for the meta-package (fldigi-full was a wild guess),
  2. fl{amp,cluster,msg} failing to set USE_X (I left a writeup in the flamp template), and
  3. the applications that do build presenting an all-black theme: black font on black background. Just my machine (running sway), or something wrong with the way I built the programs?

Testing the changes

  • I tested the changes in this PR: briefly

New package

@classabbyamp classabbyamp added WIP Work in progress new-package This PR adds a new package labels Aug 21, 2022
@classabbyamp
Copy link
Member

I'm not sure we need a metapackage for all of them

@Goorzhel Goorzhel changed the title New packages: fl{aa,amp,cluster,log,msg,net,wkey,wrap,digi-full} New packages: fl{aa,amp,cluster,log,msg,net,wkey,wrap} Aug 21, 2022
@Goorzhel
Copy link
Contributor Author

Goorzhel commented Aug 21, 2022

fl{amp,cluster,msg} failing to set USE_X

I was missing hostmakedepends="pkg-config".

@classabbyamp
Copy link
Member

image

can confirm the weirdness. Also, I don't appear to be able to open any of the menus at the top, fllog just freezes

@classabbyamp
Copy link
Member

ok the same colour thing is happening in fldigi, but not flrig

@Goorzhel
Copy link
Contributor Author

Goorzhel commented Sep 7, 2022

I could reproduce the weirdness of flamp on two OSes set up somewhat identically (i.e., running sway upon seatd):

  • FreeBSD 13.1-R, pkg install -y flamp
  • NixOS 22.05.2512.a82127cea64, built from upstream tarball in nix-shell -p pkgconfig -p fltk

@classabbyamp doesn't use Wayland, so it's probably not something specific to Wayland either. (Even so, I should try to reproduce this in an X environment.) Nor does it seem specific to fltk alone, because dillo is built on fltk and I saw no problems there.

@classabbyamp
Copy link
Member

I think this is something to bring up upstream

@Goorzhel
Copy link
Contributor Author

Goorzhel commented Sep 7, 2022

ok the same colour thing is happening in fldigi, but not flrig

On FreeBSD, both work. On NixOS, flrig works, and fldigi behaves like flamp.

I think this is something to bring up upstream

Agreed. I'll submit a bug report eventually.

@Goorzhel
Copy link
Contributor Author

Goorzhel commented Sep 22, 2022

I left fltk-devel as a depends in one of the packages. 🤡

EDIT: I also sent that bug report.

@Goorzhel
Copy link
Contributor Author

The problem went away for @classabbyamp (bspwm), but not for me (sway). I definitely need to try an X environment.

@Goorzhel
Copy link
Contributor Author

I tried six different environments — {{Void,FreeBSD} laptop,NixOS VM} plus {sway,i3} — and the fltk test programs displayed correctly only on the NixOS VM, in both X and Wayland.

I wanted to figure out what NixOS was doing differently, but I went about it in a very caveman-like way: I went back to the Void system and tried compiling with each dependency I figured I was missing, one-by-one:

$ xi -y libXft-devel
$ ./configure && make -j8 && test/preferences && make clean
$ # and so on, for libX{inerama,cursor,fixes,...}

But I couldn't get the all-black UI to go away. I also tried ./configure --enable-local{jpeg,zlib,png} — same behavior.

There is almost certainly something very stupid I'm missing. But I'll devote some more time to finding it before asking up-upstream.

@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Dec 25, 2022
@Goorzhel Goorzhel closed this Dec 27, 2022
@the-maldridge the-maldridge reopened this Dec 27, 2022
@Goorzhel
Copy link
Contributor Author

I was close to giving up on this but there's less work left than I thought. I just need to redo the fltk tests, take some screenshots, and file an issue at github.com/fltk/fltk.

@Goorzhel
Copy link
Contributor Author

Well, damn. I downloaded the latest FLTK snapshot (fltk/fltk@e7eac09c), compiled the tests, and saw them display perfectly. Then I downloaded the 1.3.8 release separately, compiled the tests there*, and got that all-black UI again.

It seems this is stuck until FLTK 1.4.

* ./configure && make -j8 && ./test/preferences

@Goorzhel
Copy link
Contributor Author

@classabbyamp, if you have a spare moment can you download the two tarballs I linked above and try ./configure && make -j8 && ./test/preferences inside each of them?

@github-actions github-actions bot removed the Stale label Dec 28, 2022
@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants