New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common/build-style/gnu-makefile.sh: define prefix, PREFIX for build #38823
common/build-style/gnu-makefile.sh: define prefix, PREFIX for build #38823
Conversation
8fd1334
to
eea6968
Compare
Can you mention in the commit message that this allows us to remove the definition from other templates, and that it avoids having to catch every time something needs PREFIX defined there? That history won't always be obvious. I would already go with an additional |
eea6968
to
9127629
Compare
How's what I wrote?
done for almost everything, a couple had build failures or needed updates, which will be addressed separately |
9127629
to
927b0be
Compare
927b0be
to
a5ba409
Compare
this allows removing the definition from templates, and avoids issues where the prefix is used during build.
make_install_args is not set to anything by default. STRIP=true PREFIX=/usr prefix=/usr DESTDIR=${DESTDIR} is set outside of make_install_args for gnu-makefile only.
not revbumping due to build failure (void-linux#38835)
a5ba409
to
d4a3a1e
Compare
Testing the changes
Should fix some issues where PREFIX or prefix is used during build, like with netsurf (b785368)
[ci skip]