Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/build-style/gnu-makefile.sh: define prefix, PREFIX for build #38823

Merged
merged 55 commits into from Aug 24, 2022

Conversation

classabbyamp
Copy link
Member

@classabbyamp classabbyamp commented Aug 22, 2022

Testing the changes

  • I tested the changes in this PR: briefly

Should fix some issues where PREFIX or prefix is used during build, like with netsurf (b785368)

[ci skip]

@classabbyamp classabbyamp added the xbps-src xbps-src related label Aug 22, 2022
@ericonr
Copy link
Member

ericonr commented Aug 22, 2022

Can you mention in the commit message that this allows us to remove the definition from other templates, and that it avoids having to catch every time something needs PREFIX defined there? That history won't always be obvious.

I would already go with an additional srcpkgs/: commit removing it from templates as well.

@classabbyamp
Copy link
Member Author

Can you mention in the commit message that this allows us to remove the definition from other templates, and that it avoids having to catch every time something needs PREFIX defined there? That history won't always be obvious.

How's what I wrote?

I would already go with an additional srcpkgs/: commit removing it from templates as well.

done for almost everything, a couple had build failures or needed updates, which will be addressed separately

this allows removing the definition from templates, and avoids issues
where the prefix is used during build.
make_install_args is not set to anything by default.
STRIP=true PREFIX=/usr prefix=/usr DESTDIR=${DESTDIR} is set outside of
make_install_args for gnu-makefile only.
not revbumping due to build failure (void-linux#38835)
@classabbyamp classabbyamp merged commit d4a3a1e into void-linux:master Aug 24, 2022
@classabbyamp classabbyamp deleted the gnu-make-build-pfx branch August 24, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
xbps-src xbps-src related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants