Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3-dateparser: update to 1.1.1, patch breakage on python3-regex #38833

Closed
wants to merge 1 commit into from

Conversation

icp1994
Copy link
Contributor

@icp1994 icp1994 commented Aug 22, 2022

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, x86_64

Note that the breakage is not caused by updating the package rather due to an API change introduced in python3-regex-2022.3.15. Upstream mitigates this by pinning to an older version of that regex library in their setup.py but that doesn't work for distro packages. This patch is deemed sufficient by one of the dateparser authors as a temporary fix till they make a new release with a proper fix.

Only one package, Komikku-0.40.0 depends on this currently.

@icp1994
Copy link
Contributor Author

icp1994 commented Aug 22, 2022

One test failed (23421 passed) only on the x86_64-musl instance. From the test's name it's due to that container having non-english locale.

edit: I see now that the glibc build starts with

Generating GNU libc locales...
  C.UTF-8... done.
  en_US.UTF-8... done.
glibc-locales: configuring ...
glibc-locales: configured successfully.

which is obviously missing in musl build.

@sgn sgn closed this in 236c264 Sep 6, 2022
@icp1994 icp1994 deleted the python3-dateparser branch September 7, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant