thunderbird: update to 102.2.1. (Several high impact CVEs) #38919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dataCobra
force-pushed
the
thunderbird-update-102.2
branch
from
455d7ba
to
2a2939b
Compare
dataCobra
changed the title
|
can you determine if the |
|
I'll check. I forgot to [ci skip] before hand. Could you stop the checking? |
It seems like |
|
do_build() fails for |
|
I've tested this and it works fine on x86_64. I'm actively using the updated version without issues. |
|
@meator good to know. 👍 Sadly I don't get the i686 Version to build. :-( |
|
The posted error log is incomplete, there are builds happening in parallel, the error probably happens a little bit earlier. Look for |
|
Hey @Duncaen, I've looked a bit further in the logs and found the following error message. I'll try to build with |
|
Parallel build is fine, just that you have to keep that in mind when looking for errors. |
|
Could this be the issue or should I need to look a bit further? |
|
Would be interesting to know the context from where is headers is included and the used cflags, this works fine for firefox.
This is definitively an issue, that needs to be fixed. |
|
Is this an issue with thunderbird or gcc? Sorry I just wanted to help with getting the update out. My knowledge regarding thunderbird is almost zero. 🙁 |
|
Don't know enough context to be sure, but it might be related to the Edit: hm no its not, our template just disables rust simd. |
|
Its probably not that, the template disables rust-simd already, need more context from where those header files are included. |
|
I'll read the logs this evening and try to get some more information regarding this issue. Maybe then I'll find a solution by myself. If not, I'll let you know. Thanks for all the help, I really appreciate that! 👍 |
|
I've found some more information in the logs. The following things might be interessting: Here is the full other part: |
|
I've found this rust-lang/rust#45403 regarding the issue. |
|
the vsed on line 166 of the thunderbird template didn't change anything for me, that should be looked into and fixed |
|
what arch is your masterdir? are you cross-building to i686? I am unable to reproduce your error locally. You should be using an i686 masterdir instead of cross-building for i686. |
Alright this might be the issue. I've tried to crossbuild thunderbird... |
|
I'll force push my branch. |
dataCobra
force-pushed
the
thunderbird-update-102.2
branch
from
2a2939b
to
f884443
Compare
|
Alright, these are the most recent changes I made. Building of |
dataCobra
force-pushed
the
thunderbird-update-102.2
branch
from
f884443
to
533392f
Compare
dataCobra
force-pushed
the
thunderbird-update-102.2
branch
from
533392f
to
c11b4e6
Compare
dataCobra
changed the title
|
have you had a chance to runtime-test this? |
No I didn't had the chance to runtime-test this. I use neomutt as my daily driver. |
|
I assume that the thunderbird team didn't introduce breaking changes in this new version. |
|
Currently I'm also building thunderbird natively for i686. At the moment there are no errors. |
|
I know that it's not good practice to just merge something without much testing. Do you've the chance to test this? If not I need to create a VM to test the basic stuff. |
|
The i686 version build successfully. 👍 |
|
I guess I'll join in for the second time. c11b4e6 is working well on x86_64-glibc. I'm actively using it without issues. I kinda hope this PR won't be updated again because it took me 5 hours to rebuild this. |
That's good to know. Thank you for the info. 👍 I'll not update the PR again. 🙂 |
classabbyamp
removed
the
needs-testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for several high impact CVEs
https://www.mozilla.org/en-US/security/advisories/mfsa2022-36/
Testing the changes
Local build testing
[ci skip]