Fix qbittorrent crash on musl #39154
Conversation
|
I opened a PR because I'm not sure if there's any other package using asio that needs to be rebuilt. |
srcpkgs/boost/patches/align.patch
Outdated
| #include <unistd.h> | ||
| #endif | ||
|
|
||
| -#if defined(__APPLE__) || defined(__APPLE_CC__) || defined(macintosh) |
There was a problem hiding this comment.
Please don't patch this, add -D_POSIX_C_SOURCE=201112L instead, or alternately, patch only last 2 legs.
The diff looks like you're removing all legs but SunOS.
There was a problem hiding this comment.
I don't want to fix this with a define in CXXFLAGS because it requires fixing in all packages that use the library, instead of a single fix in the library.
If I manage to rework the patch to look like the posix version is the one being kept or add a comment making that clear and that it's because, as a distro, we know where these headers are being used, would it be okay for you?
There was a problem hiding this comment.
I guess reworking the last fallback to just include the posix version would be equivalent, and I'd be okay with it.
There was a problem hiding this comment.
I think it's better to #include <features.h> in boost/config.hpp. Just in case other headers (now or later) decide to use feature test macros.
Reported-by: Érico Nogueira <erico.erc@gmail.com>
Since asio is a header-only library, we need to rebuild its dependents.
Testing the changes