Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: atftp-0.8.0 #39250

Closed
wants to merge 1 commit into from

Conversation

jcgruenhage
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: briefly

@classabbyamp classabbyamp added the new-package This PR adds a new package label Sep 12, 2022
@jcgruenhage
Copy link
Contributor Author

Okay, so I looked a bit into the test failures, and it's basically this bit not working:

start_server() {
    # start a server
    echo -n "Starting 'atftpd "${SERVER_ARGS/ \*/ /}"', "
    $ATFTPD $SERVER_ARGS > $SERVER_LOG &
    if [ $? != 0 ]; then
	echo "Error starting server."
	exit 1
    fi
    sleep 1
    ATFTPD_PID=$!
    # test if server process exists
    if ! ps -p $ATFTPD_PID >/dev/null 2>&1 ; then
	echo "Server process died!"
	exit 1
    fi
    echo "PID: $ATFTPD_PID"
    trap stop_and_clean EXIT SIGINT SIGTERM
}

It prints out that the server process has died, but that wasn't actually accurate. The server was still running, and the test script was hanging until I explicitly stopped it.

Unless anyone has a more concrete idea on why that is, I'd just mark this as make_check=no for now.

@jcgruenhage jcgruenhage marked this pull request as ready for review September 14, 2022 10:00
@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@jcgruenhage
Copy link
Contributor Author

Not stale.

@github-actions github-actions bot removed the Stale label Dec 15, 2022
@Piraty
Copy link
Member

Piraty commented Mar 5, 2023

i had a hunch that ps is missing. i was right.
tests succeed with checkdepends="procps-ng"

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Jun 5, 2023
@github-actions github-actions bot closed this Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants