id3lib: patch for c99 bool #39275
Merged
id3lib: patch for c99 bool #39275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtboehlke
force-pushed
the
id3lib
branch
2 times, most recently
from
e161b6b
to
2f58083
Compare
|
@sgn Not sure what happened to your comment, but I removed the revbump to castget. Edit: and I misread it as well, sorry about that. Should this include a revbump for castget, since all it does is fix the build? |
sgn
reviewed
Sep 15, 2022
sgn
added a commit
to mtboehlke/void-packages
that referenced
this pull request
Sep 15, 2022
id3/globals.h has a typedef for bool which is incompatible with c99 stdbool. This is a known issue, but upstream is effectively unmaintained. See https://sourceforege.net/p/id3lib/mailman/message/30500558/ Close: void-linux#39275
|
@sgn thanks for jumping in on this! |
|
As discussed on IRC, we need to patch all |
id3/globals.h has a typedef for bool which is incompatible with c99 stdbool which is available transitively via stdlib.h Also C99 bool and C++ bool is incompatible with original id3lib's bool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
id3/globals.h has a typedef for bool which is incompatible with c99 stdbool.
This is a known issue, but upstream is effectively unmaintained.
See this thread from upstream.
This only seems to be an issue for castget while building, and they have already switched to using taglib for the next release.
Castget issue.
Testing the changes