Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binutils: update to 2.39. #39312

Closed
wants to merge 28 commits into from
Closed

binutils: update to 2.39. #39312

wants to merge 28 commits into from

Conversation

oreo639
Copy link
Member

@oreo639 oreo639 commented Sep 16, 2022

Testing the changes

  • I tested the changes in this PR: briefly

[ci skip]

Most of the testing for this was done as a part of the gcc12 PR, this was split on request.

There were some api changes in libfd, the following packages were tested to build against binutils-devel:

  • oprofile
  • prelink-cross
  • kcov
  • linux-tools
  • distcc
  • chroot-distcc
  • sbsigntool
  • llvm12 (I can't remember if I tested it with binutils 2.39 or just 2.38, building it takes forever, but it should be fine since afaict it doesn't use libbfd or dis-asm.h)
  • rpm (doesn't actually use binutils-devel but it is listed in the makedepends, builds fine without it)

Please test this PR before merging.

Closes: #39291

@oreo639 oreo639 changed the title Binutils binutils: update to 2.39. Sep 16, 2022
@oreo639 oreo639 force-pushed the binutils branch 2 times, most recently from 96296ac to aa2562c Compare September 16, 2022 13:28
@dkwo
Copy link
Contributor

dkwo commented Sep 16, 2022

Does it make sense to include here also the cross-* commits from the gcc PR, with just the updated binutils part?

@oreo639
Copy link
Member Author

oreo639 commented Sep 16, 2022

Does it make sense to include here also the cross-* commits from the gcc PR, with just the updated binutils part?

Good point. Thanks.

@oreo639 oreo639 force-pushed the binutils branch 3 times, most recently from 07bfd72 to c560865 Compare September 17, 2022 05:09
@dkwo
Copy link
Contributor

dkwo commented Sep 17, 2022

Thanks. Do you mind fixing the trivial lint errors for the cross* pkgs?
It's a bit tedious, but this way we may catch other stuff when CI goes through.

@dkwo
Copy link
Contributor

dkwo commented Sep 17, 2022

Sorry, ignore my previous comment.
It's enough to remove ci skip to let it go through ci.

@paper42
Copy link
Member

paper42 commented Sep 17, 2022

Sorry, ignore my previous comment.
It's enough to remove ci skip to let it go through ci.

ci skip is here for a reason, building cross-* would time out anyway

@oreo639
Copy link
Member Author

oreo639 commented Dec 17, 2022

Already completed as a part of the gcc 12 PR.

@oreo639 oreo639 deleted the binutils branch December 17, 2022 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants