Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libtool: update to 2.4.7. #39313

Merged
merged 1 commit into from Nov 17, 2022
Merged

libtool: update to 2.4.7. #39313

merged 1 commit into from Nov 17, 2022

Conversation

oreo639
Copy link
Member

@oreo639 oreo639 commented Sep 16, 2022

Testing the changes

  • I tested the changes in this PR: briefly

Most of the testing for this was done as a part of the gcc12 PR, this was split on request.

Most of the build failures experienced were due to hardcoded version-mismatches and the libtool files not getting regenerated properly.
This also defines lt_cv_shlibpath_overrides_runpath=yes on musl since it always searches LD_LIBRARY_PATH before RPATH and RUNPATH and not defining it causes some tests to fail which verify this behavior.

Please test this PR before merging.

@oreo639 oreo639 changed the title Libtool libtool: update to 2.4.7. Sep 16, 2022
@oreo639 oreo639 force-pushed the libtool branch 11 times, most recently from d3eab4e to 6f0d67a Compare September 16, 2022 14:57
srcpkgs/libtool/template Outdated Show resolved Hide resolved
srcpkgs/libsasl/template Outdated Show resolved Hide resolved
@dkwo
Copy link
Contributor

dkwo commented Sep 16, 2022

I wonder if this also fixes the failing ntl build on aarch64-musl #37497
I'll have a machine to test it in a few weeks.

@dkwo
Copy link
Contributor

dkwo commented Oct 5, 2022

@paper42 Do you have a quick way of building ntl natively on aarch64-musl using this pr?

@dkwo
Copy link
Contributor

dkwo commented Oct 10, 2022

Built and checked this PR for aarch64-musl.
It also fixes the previously reported ntl build failure #37497 @tornaria

@oreo639 oreo639 marked this pull request as draft November 3, 2022 20:46
@dkwo
Copy link
Contributor

dkwo commented Nov 16, 2022

@oreo639 what is the status of this? can you rebase it?

@oreo639
Copy link
Member Author

oreo639 commented Nov 16, 2022

what is the status of this?

I temporarily marked it as a draft because wanted to make sure this didn't get merged with an outdated changeset.

@oreo639
Copy link
Member Author

oreo639 commented Nov 16, 2022

The libtool tests are failing due to the grep update.

@oreo639 oreo639 force-pushed the libtool branch 6 times, most recently from 82fba21 to 386d659 Compare November 17, 2022 00:24
@oreo639 oreo639 force-pushed the libtool branch 4 times, most recently from 2621d18 to 50c183b Compare November 17, 2022 17:46
Removed vsed host=${_canonical_host} because _canonical_host is derrived from
host, so they should always be the same.
@paper42 paper42 merged commit f6eeded into void-linux:master Nov 17, 2022
@oreo639 oreo639 deleted the libtool branch November 17, 2022 20:53
@dkwo
Copy link
Contributor

dkwo commented Nov 17, 2022 via email

@oreo639
Copy link
Member Author

oreo639 commented Nov 17, 2022

I can't build natively on aarch64.
Build the packages with -C and try running a diff between them and let me know what the difference is.

@oreo639
Copy link
Member Author

oreo639 commented Nov 18, 2022

Oh I see:

# The directories searched by this compiler when creating a shared library.
compiler_lib_search_dirs="/usr/lib/gcc/aarch64-linux-gnu/10.2.1 /usr/lib/gcc/aarch64-linux-gnu/10.2.1/../../../../aarch64-linux-gnu/lib/../lib64 /usr/aarch64-linux-gnu/lib/../lib64 /usr/aarch64-linux-gnu/usr/lib/../lib64 /usr/lib/gcc/aarch64-linux-gnu/10.2.1/../../../../aarch64-linux-gnu/lib /usr/aarch64-linux-gnu/lib /usr/aarch64-linux-gnu/usr/lib"

# Dependencies to place before and after the objects being linked to
# create a shared library.
predep_objects="/usr/lib/gcc/aarch64-linux-gnu/10.2.1/../../../../aarch64-linux-gnu/lib/../lib64/crti.o /usr/lib/gcc/aarch64-linux-gnu/10.2.1/crtbeginS.o"
postdep_objects="/usr/lib/gcc/aarch64-linux-gnu/10.2.1/crtendS.o /usr/lib/gcc/aarch64-linux-gnu/10.2.1/../../../../aarch64-linux-gnu/lib/../lib64/crtn.o"
predeps=""
postdeps="-lstdc++ -lm -lgcc_s -lc -lgcc_s"

# The library search path used internally by the compiler when linking
# a shared library.
compiler_lib_search_path="-L/usr/lib/gcc/aarch64-linux-gnu/10.2.1 -L/usr/lib/gcc/aarch64-linux-gnu/10.2.1/../../../../aarch64-linux-gnu/lib/../lib64 -L/usr/aarch64-linux-gnu/lib/../lib64 -L/usr/aarch64-linux-gnu/usr/lib/../lib64 -L/usr/lib/gcc/aarch64-linux-gnu/10.2.1/../../../../aarch64-linux-gnu/lib -L/usr/aarch64-linux-gnu/lib -L/usr/aarch64-linux-gnu/usr/lib"

That's definitely not right.

The cross compiler paths are supposed to have gotten wiped out here:
https://github.com/oreo639/void-packages/blob/b255a33115e72d753a90432950c3864be983606e/srcpkgs/libtool/template#L44-L46
But since these are relative paths, they leaked through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants