New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libtool: update to 2.4.7. #39313
libtool: update to 2.4.7. #39313
Conversation
d3eab4e
to
6f0d67a
Compare
I wonder if this also fixes the failing |
@paper42 Do you have a quick way of building ntl natively on aarch64-musl using this pr? |
@oreo639 what is the status of this? can you rebase it? |
I temporarily marked it as a draft because wanted to make sure this didn't get merged with an outdated changeset. |
The libtool tests are failing due to the grep update. |
82fba21
to
386d659
Compare
2621d18
to
50c183b
Compare
Removed vsed host=${_canonical_host} because _canonical_host is derrived from host, so they should always be the same.
it seems there's yet another cross-compilation issue with libtool:
if i use the packaged libtool to compile ntl, then it fails,
as previously reported, while if i natively compile libtool first,
then I can successfully use it to build ntl (on aarch64),
including passing tests.
|
I can't build natively on aarch64. |
Oh I see:
That's definitely not right. The cross compiler paths are supposed to have gotten wiped out here: |
Testing the changes
Most of the testing for this was done as a part of the gcc12 PR, this was split on request.
Most of the build failures experienced were due to hardcoded version-mismatches and the libtool files not getting regenerated properly.
This also defines
lt_cv_shlibpath_overrides_runpath=yes
on musl since it always searches LD_LIBRARY_PATH before RPATH and RUNPATH and not defining it causes some tests to fail which verify this behavior.Please test this PR before merging.