qflipper: update to 1.1.3. #39325
Merged
qflipper: update to 1.1.3. #39325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RunningDroid
force-pushed
the
update_qflipper
branch
2 times, most recently
from
c79cd5b
to
5504175
Compare
sgn
reviewed
Sep 18, 2022
srcpkgs/qflipper/template
Outdated
| wrksrc="qFlipper-${version}" | ||
| build_style=qmake | ||
| configure_args="-spec linux-g++ CONFIG+=qtquickcompiler DEFINES+=DISABLE_APPLICATION_UPDATES" |
sgn
reviewed
Sep 18, 2022
srcpkgs/qflipper/template
Outdated
| revision=1 | ||
| _nanopb_version=0.4.5 | ||
| archs="~i686" #https://github.com/flipperdevices/qFlipper/issues/120 |
There was a problem hiding this comment.
How come it's buildable for arm 32bit?
There was a problem hiding this comment.
Well, because you're doing it wrong. Those addition *-devel packages in hostmakedepends is wrong!!
There was a problem hiding this comment.
Sorry, I added the *-devel packages to hostmakedepends because the cross builds on my machine were complaining about being unable to find the QT modules for those packages and that appeared to resolve it.
There was a problem hiding this comment.
Don't add -spec into configure args, it will be set by build-style and some magic needs to be done for cross compilation.
In the end of the day, it will use same spec with linux-g++
sgn
requested changes
Sep 18, 2022
sgn
added a commit
to RunningDroid/void-packages
that referenced
this pull request
Sep 18, 2022
- disable building on i686 and point to upstream bug flipperdevices/qFlipper#120 - add configure args that upstream recommends: https://github.com/flipperdevices/qFlipper#standalone-build - add configure arg to disable update checker Close: void-linux#39325
sgn
force-pushed
the
update_qflipper
branch
from
5504175
to
a21ad60
Compare
sgn
force-pushed
the
update_qflipper
branch
from
a21ad60
to
c429ad0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes