Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: yabridgectl-4.0.2 #39476

Closed
wants to merge 1 commit into from

Conversation

ajtcode71
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

New package

xlint check complains about the wrksrc not being top level. The source of yabridgectl is distributed within the yabridge source and is several levels down. Compiles and works well by keeping the origin source in the correct locations and having the multilevel wrksrc set.

Local build testing

  • I built this PR locally for my native architecture, (ARCH-LIBC)

@classabbyamp classabbyamp added the new-package This PR adds a new package label Sep 26, 2022
@paper42
Copy link
Member

paper42 commented Sep 26, 2022

please force push to update an existing PR instead of spamming everyone with closing and opening a new one #39474

xlint check complains about the wrksrc not being top level. The source of yabridgectl is distributed within the yabridge source and is several levels down. Compiles and works well by keeping the origin source in the correct locations and having the multilevel wrksrc set.

try using build_wrksrc

pkgname=yabridgectl
version=4.0.2
revision=1
archs="x86_64"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was not resolved, unmarking as resolved

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you keep marking this as resolved? I would like to see a reason first. Does it not work on musl? on i686? Are cross builds broken? Why?

@paper42
Copy link
Member

paper42 commented Sep 26, 2022

This PR should contain one commit with a standard commit message, see https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#committing-your-changes

@ajtcode71 ajtcode71 force-pushed the yabridgectl branch 3 times, most recently from 5eb98a2 to 1ff112c Compare October 1, 2022 08:16
wrksrc="yabridge-${version}"
build_wrksrc="tools/yabridgectl"
build_style=cargo
hostmakedepends="grep"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Dec 31, 2022
@github-actions github-actions bot closed this Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants