Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wireplumber: update to 0.4.12, drop dbus check from service file #39720

Closed
wants to merge 1 commit into from

Conversation

dkwo
Copy link
Contributor

@dkwo dkwo commented Oct 4, 2022

  • I tested the changes in this PR: YES
  • I built this PR locally for my native architecture, (x86_64-musl)

According to https://gitlab.freedesktop.org/pipewire/wireplumber/-/issues/237 and https://forum.artixlinux.org/index.php/topic,4230.0.html , DBUS is not required, so I dropped it from the service file: everything is working as expected.
(No dbus, no elogind, no membership in audio group: just using seatd and run wireplumber as root using the provided service, my user is member of pipewire group.)

@ericonr @ahesford @Animeshz

@Duncaen
Copy link
Member

Duncaen commented Oct 4, 2022

Does everything that depends on dbus in wireplumber still work if dbus is not available on startup? (bluez)?

@ahesford
Copy link
Member

ahesford commented Oct 4, 2022

I think it's fine to drop dbus from a service we generally advise against, but if you're going to drop the check, you should also drop the dbus-run-session wrapper around the wireplumber execution.

@Duncaen
Copy link
Member

Duncaen commented Oct 4, 2022

But its a regression for anyone currently using it, not enabling dbus cripples wireplumber quite a bit. IMHO it would make more sense to let users who don't want to use dbus write their own service if they want to run a system-wide wireplumber.

@Duncaen
Copy link
Member

Duncaen commented Oct 4, 2022

But then again, including system wide services as long as they are not fully supported was probably a mistake, just like with pulse.

@dkwo
Copy link
Contributor Author

dkwo commented Oct 4, 2022

@Duncaen I see your point. Can you test whether this breaks dbus dependants? I have no such stuff on my machine right now.

@Duncaen
Copy link
Member

Duncaen commented Oct 4, 2022

I'm not sure, from just running it manually it seems like modules not being loaded if dbus is not available.

@dkwo
Copy link
Contributor Author

dkwo commented Oct 11, 2022

Let me close this, as it's not clear it's actually a good idea.

@dkwo dkwo closed this Oct 11, 2022
@dkwo dkwo deleted the wir branch February 13, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants