Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: ytfzf-2.5.0 #39746

Closed
wants to merge 2 commits into from
Closed

New package: ytfzf-2.5.0 #39746

wants to merge 2 commits into from

Conversation

BryceVandegrift
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

New package

I think that this package should be installed system wide, especially since the addition of man pages to this program. There is also an "addons" system, if that warrants any sort of consideration (addons could be added as separate packages).

@classabbyamp classabbyamp added the new-package This PR adds a new package label Oct 5, 2022
@classabbyamp
Copy link
Member

classabbyamp commented Oct 5, 2022

Simple shell scripts are unlikely to be accepted unless they provide considerable value to a broad user base

(CONTRIBUTING.md)

does being system-provided/installed provide any benefits vs just downloading the script?

@BryceVandegrift
Copy link
Contributor Author

BryceVandegrift commented Oct 5, 2022

Installing it system-wide would provide man pages to user(s) instead of just running it as a local script. Addons are also installed by default into a root-owned directory if that's anything to add. This package is similar to pass in how it is structured, as well as popularity although the ecosystem isn't that big.

@classabbyamp
Copy link
Member

would provide man pages

might want to install those then

@BryceVandegrift
Copy link
Contributor Author

Oh, sorry about that mistake on my end, I'll fix it.

@BryceVandegrift
Copy link
Contributor Author

That's weird, xlint on my system gives no errors at all.

@classabbyamp
Copy link
Member

it's the commit lint, which is a separate script.

also, this pr shoukd be one commit

@BryceVandegrift
Copy link
Contributor Author

Ok, the pr should be good.

@abenson
Copy link
Contributor

abenson commented Oct 6, 2022

CONTRIBUTING.md

for new packages, use New package: <pkgname>-<version> (example).

@BryceVandegrift BryceVandegrift changed the title Added package: ytfzf-2.5.0 New package: ytfzf-2.5.0 Oct 6, 2022
@BryceVandegrift
Copy link
Contributor Author

BryceVandegrift commented Oct 7, 2022

Ok, everything should be good.

@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Jan 12, 2023
@BryceVandegrift BryceVandegrift closed this by deleting the head repository Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants