Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apl: disable werror #39750

Merged
merged 1 commit into from Oct 7, 2022
Merged

apl: disable werror #39750

merged 1 commit into from Oct 7, 2022

Conversation

oreo639
Copy link
Member

@oreo639 oreo639 commented Oct 5, 2022

Testing the changes

  • I tested the changes in this PR: briefly

@oreo639 oreo639 changed the title Apl apl: disable werror Oct 5, 2022
@oreo639 oreo639 mentioned this pull request Oct 5, 2022
Closed
44 tasks
sgn
sgn reviewed Oct 6, 2022
View reviewed changes
srcpkgs/apl/template Outdated Show resolved Hide resolved
@sgn
Copy link
Member

sgn commented Oct 6, 2022

The build seems to do some sneaky with CFLAGS, -g has been eaten.

@oreo639
Copy link
Member Author

oreo639 commented Oct 6, 2022 •
edited

The build seems to do some sneaky with CFLAGS, -g has been eaten.

Hrm. It does show up when compiling with debug packages enabled, though.

@sgn
Copy link
Member

sgn commented Oct 7, 2022

We need to patch their config to not screw with our flags.

@sgn sgn merged commit 93ebe02 into void-linux:master Oct 7, 2022
@oreo639 oreo639 deleted the apl branch October 7, 2022 02:03
@oreo639 oreo639 mentioned this pull request Oct 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgn sgn sgn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oreo639 @sgn