Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Package: citations-0.5.1 #39754

Merged
merged 1 commit into from Oct 20, 2022
Merged

Conversation

misuchiru03
Copy link
Contributor

@misuchiru03 misuchiru03 commented Oct 6, 2022

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64-GLIBC)
  • aarch64-musl
  • aarch64
  • armv7l

@misuchiru03
Copy link
Contributor Author

I do not think it likes being cross-compiled. I do not have an armv7l or aarch64 machine to verify native builds.

@classabbyamp
Copy link
Member

add build_helper=rust, at minimum. you may need rust-std in makedepends

@paper42 paper42 added the new-package This PR adds a new package label Oct 6, 2022
@misuchiru03
Copy link
Contributor Author

add build_helper=rust, at minimum. you may need rust-std in makedepends

That would be it, among a few other changes. Thanks!
I've got it building aarch64 right now. Once completed, will push updated template.

@misuchiru03
Copy link
Contributor Author

If the package is built natively, it is fine as is. There is a build.ninja that expects the file to build natively and the cross build places the built files in a different location so cross builds fail. I have added a check for Cross Build only to make sure it finds the file properly and cross builds built fine on my system.

# Allows the cross build to know where the file is placed--build.ninja does not account for cross build
pre_build() {
if [ "${CROSS_BUILD}" ]; then
sed -i 's, && cp src/release/citations src/citations,,' ${_meson_builddir}/build.ninja
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use vsed

@abenson abenson merged commit 37c015f into void-linux:master Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants