Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "python3-poetry-core: update to 1.3.1." #39777

Closed
wants to merge 1 commit into from

Conversation

icp1994
Copy link
Contributor

@icp1994 icp1994 commented Oct 6, 2022

I messed the last commit since I forgot use XBPS_CHECK_PKGS=yes while packaging two revdeps today. so even though it builds, it fails test(s) and errs in runtime.

This reverts commit 25dfe0b.

Synapse is having runtime issues.

matrix-org/synapse#14079.
@ahesford
Copy link
Member

ahesford commented Oct 6, 2022

Synapse really doesn't seem to have its act together wrt dependency handling and, if that's the only problem, I'm reluctant to revert a perfectly reasonable update because of their pointless dependency checks.

What happens if you patch the dependency check at https://github.com/matrix-org/synapse/blob/7b67e93d499cb45f7217e9dfea046ed8b5c455fd/synapse/config/repository.py#L206-L208 to look for url-preview instead of url_preview?

@icp1994
Copy link
Contributor Author

icp1994 commented Oct 6, 2022

There are some "official" pulls: matrix-org/synapse#14080 & matrix-org/synapse#14085

@ahesford
Copy link
Member

ahesford commented Oct 6, 2022

matrix-org/synapse#14085 looks like the way to go.

@icp1994
Copy link
Contributor Author

icp1994 commented Oct 6, 2022

Should I wait for it to merge? As the previous one got reverted in the second one and there's some unresolved comments.

@ahesford
Copy link
Member

ahesford commented Oct 6, 2022

Yeah, see what they eventually merge before pulling the patch.

@reivilibre
Copy link

pointless dependency checks

The dependency checks are not pointless; they prevent you from running Synapse with out of date deps, which isn't hard to do due to the absolute minefields in installing Python packages. They were added after getting enough bug reports from people doing that, which ultimately takes a lot of time and effort to respond to.

Synapse really doesn't seem to have its act together wrt dependency handling

Problem is that everything is a damned if you do, damned if you don't situation. There are many ways to install Synapse and distro packages are but some of them :).
We do make a lot of effort to keep things workable for distro packages but having old versions break under our feet because of dependency changes is also a massive pain to deal with. If you're aware of better ways of doing this then let us know.

@ahesford
Copy link
Member

ahesford commented Oct 7, 2022

I apologize; my comment was a bit harsh.

The underlying problem is the fragmented and constantly changing official view of Python packaging building and distribution. PyPA seems to take the view that only pip matters, but they haven't addressed the first half of the packaging problem adequately and pip is a terrible package manager. The search sub-command has been broken by design for years because they don't seem to know how to rate-limit spammy queries; at this point why does it still exist? Even worse, why does the package manager happily let you install entirely new dependency chains and only after the fact warn you about conflicting version restrictions?

It's only natural that each project tries to work around a sea of inconsistent and half-formed tooling with unique hacks, but that just causes problems elsewhere. Damned whether you do or don't, indeed.

@reivilibre
Copy link

The underlying problem is the fragmented and constantly changing official view of Python packaging building and distribution

Indeed and agreed with your entire post; we all feel this pain whenever anything like this happens. (Which has been way too frequently in recent weeks for my liking.)

@ahesford ahesford closed this in be548bc Oct 7, 2022
@icp1994 icp1994 deleted the python3-poetry-core branch October 18, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants