Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: headscale-0.16.4 #39864

Closed
wants to merge 1 commit into from
Closed

Conversation

teldra
Copy link
Contributor

@teldra teldra commented Oct 10, 2022

Testing the changes

  • I tested the changes in this PR: YES

New package

@classabbyamp classabbyamp added the new-package This PR adds a new package label Oct 10, 2022
@teldra
Copy link
Contributor Author

teldra commented Oct 10, 2022

Crosscompiling fails, because it compiles for host? How do I circumvent this?

@paper42
Copy link
Member

paper42 commented Oct 10, 2022

use the go build style

@teldra
Copy link
Contributor Author

teldra commented Oct 10, 2022

use the go build style

I tried but I don't get a binary. At least I don't find any

@paper42
Copy link
Member

paper42 commented Oct 10, 2022

I tried to package headscale, but didn't end up finishing it, feel free to get inspiration from here: 29f7be7

@teldra teldra force-pushed the new-headscale branch 2 times, most recently from 3d83af0 to 9bc1938 Compare October 10, 2022 22:13
@teldra
Copy link
Contributor Author

teldra commented Oct 10, 2022

Thank you @paper42, that did the trick!

@teldra teldra changed the title New Package: headscale-0.16.4 New package: headscale-0.16.4 Oct 10, 2022
srcpkgs/headscale/template Outdated Show resolved Hide resolved
checksum=0395478f9dde68aa8ca23be8df6ff636d47166981d0995e4e31a8c7db12df8e8
make_dirs="/etc/headscale 0750 _headscale _headscale
/var/lib/headscale 0750 _headscale _headscale
/var/run/headscale 0750 _headscale _headscale"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this one necessary? It is nowhere to be found in the linux setup instructions in the headscale docs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

headscale creates a sock file in this dir. (Please refer to the vsed statement in post_extract and maybe the config.yaml.)
I think, headscale is originally not intended to run as unprivileged user. I circumvent this with the creation of a headscale owned folder.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I try to maximize the ootb experience.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok yeah that dir is needed.

I think systemd (which they kinda design for) makes /var/run writable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realised that /var/run is a symlink to /run, a tmpfs; the directory will not survive a reboot.

The manual says to create the dir in the service file.

srcpkgs/headscale/template Outdated Show resolved Hide resolved
srcpkgs/headscale/template Outdated Show resolved Hide resolved
@teldra teldra force-pushed the new-headscale branch 5 times, most recently from 3d07f9c to d3e23ed Compare October 13, 2022 06:29
@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Jan 12, 2023
@github-actions github-actions bot closed this Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants