Use unique names for bulk update commands #39969
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A regression introduced in 4c43245 is causing the 'xbps-src update-sys' command to skip the final step of installing the updated packages. This happens because the `cmd` variable name clashes with a loop variable used in common/environment/setup/install.sh script (line 16). Thus the `"$cmd" == installed` comparison (common/xbps-src/shutils/bulk.sh line 122) fails and the installation step is skipped. Using unique variable names in `bulk.sh` avoids this problem.
|
Thank you for finding this, i hate shell lol. |
pfpulux
pushed a commit
to pfpulux/void-packages
that referenced
this pull request
Oct 25, 2022
A regression introduced in 4c43245 is causing the 'xbps-src update-sys' command to skip the final step of installing the updated packages. This happens because the `cmd` variable name clashes with a loop variable used in common/environment/setup/install.sh script (line 16). Thus the `"$cmd" == installed` comparison (common/xbps-src/shutils/bulk.sh line 122) fails and the installation step is skipped. Using unique variable names in `bulk.sh` avoids this problem. Closes: void-linux#39969 [via git-merge-pr]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression introduced in 4c43245 (#37700) is causing the
xbps-src update-syscommand to skip the final step of installing the updated packages.This happens because the
cmdvariable name clashes with a loop variable used in common/environment/setup/install.sh script line 16. Thus the"$cmd" == installedcomparison (common/xbps-src/shutils/bulk.sh line 122) fails and the installation step is skipped.Using unique variable names in
bulk.shavoids this problem.Testing the changes