Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vhs: update to 0.1.1 #40205

Closed
wants to merge 1 commit into from
Closed

vhs: update to 0.1.1 #40205

wants to merge 1 commit into from

Conversation

tranzystorekk
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

@tranzystorekk tranzystorekk changed the title vhs: install example tape files vhs: update to 0.1.1 Oct 28, 2022
@abenson
Copy link
Contributor

abenson commented Oct 29, 2022

I just noticed that vhs's dependency on go-rod means it breaks without chrome/chromium.

panic: [launcher] Failed to get the debug url: /usr/bin/env: ‘google-chrome-stable’: No such file or directory

@tranzystorekk
Copy link
Contributor Author

rod launcher should download chrome if it's missing, but I added chromium to depends since it's used anyway

@tranzystorekk tranzystorekk force-pushed the vhs-tapes branch 2 times, most recently from 042fa07 to 01b0bbe Compare October 30, 2022 11:51
@tranzystorekk tranzystorekk deleted the vhs-tapes branch November 2, 2022 07:54
@tranzystorekk tranzystorekk mentioned this pull request Nov 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tranzystorekk @abenson